search

filipedeschamps / rss-feed-emitter

Super RSS News Feed aggregator written in Node.js and ES6
MIT License
1.07k stars 77 forks source link

Fired 'new-item' if 'title' has changed #154

Closed ga2mer closed 7 years ago

ga2mer commented 7 years ago

If title has changed, 'new-item' fired.

Why not use 'guid' in RSS or 'id' in Atom if exists?

Like:

return _.find( feed.items, item.guid || item.id ? {
      [ item.guid ? 'guid' : 'id' ]: item.guid || item.id
    } : {
      link: item.link,
      title: item.title
    } );
filipedeschamps commented 7 years ago

@ga2mer awesome!

The logic seems fuzzy, would you mind to make a PR implementing it with a more stepped logic?