filipedeschamps / rss-feed-emitter

Super RSS News Feed aggregator written in Node.js and ES6
MIT License
1.06k stars 77 forks source link

chore(ci): support auto-releasing with semantic-release #185

Closed TobiTenno closed 4 years ago

TobiTenno commented 4 years ago

ah, looks like you added branch. problem is that since it's on my fork, that one won't exist.

TobiTenno commented 4 years ago

we might wanna remove the Travis CI - Branch build, cause that only works properly if the build started from a branch on this repo, @filipedeschamps

filipedeschamps commented 4 years ago

Done! But looks like the Travis CI - Branch Expected — Waiting for status to be reported is still stuck, even if I trig a rebuild. Maybe you need to push it again 👍

image

filipedeschamps commented 4 years ago

I gave you the wrong information, looks like everything is going to work now 👍

TobiTenno commented 4 years ago

@filipedeschamps did you add the GH token as well?

TobiTenno commented 4 years ago

I canceled the current job because it'll fail if there's no GITHUB_TOKEN with a personal access token so it can make the github release & tag & comment on the pr's

filipedeschamps commented 4 years ago

Do you know if I can create a personal token to just one repository? Anyway, probably I just need to enable repo > public_repo right?

image

TobiTenno commented 4 years ago

That seems right from what I'm reading

TobiTenno commented 4 years ago

And no, I don't know of a way for it to be limited to the one repo, but no one but the ci job will be able to release using it, so it's not like it can go haywire easily

filipedeschamps commented 4 years ago

Done 👍

image

filipedeschamps commented 4 years ago

Also, we need to add you into the NPM page, it's not fair that I'm the only one listed 👍

image

TobiTenno commented 4 years ago

feel free, i don't remember exactly how.

TobiTenno commented 4 years ago
npm ERR! code EOTP
npm ERR! This operation requires a one-time password from your authenticator.
npm ERR! You can provide a one-time password by passing --otp=<code> to the command you ran.
npm ERR! If you already provided a one-time password then it is likely that you either typoed
npm ERR! it, or it timed out. Please try again.

looks like the code you provided needs to include bypassing OTP, or you have to turn it off, unsure which you want to do.

Make sure you use the auth-only level for npm tokens? docs

filipedeschamps commented 4 years ago

Yep, I changed from Authorization and Publishing to Authorization, recreated the token and added it to Travis CI 👍

filipedeschamps commented 4 years ago

:tada: This PR is included in version 3.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

filipedeschamps commented 4 years ago

@TobiTenno that's neat 👍