search

filipedeschamps / rss-feed-emitter

Super RSS News Feed aggregator written in Node.js and ES6
MIT License
1.06k stars 77 forks source link

feat(types): add types #193

Closed TobiTenno closed 4 years ago

TobiTenno commented 4 years ago

closes #186

TobiTenno commented 4 years ago

yo, @abdatta could you take a look and make sure this is what you need?

abdatta commented 4 years ago

Hey okay, I'll take a look and let you know by tomorrow.

TobiTenno commented 4 years ago

@abdatta i got it figured out. turns out tsc that we tried to use in our build script with npx is an old deprecated copy of typescript, so we need to specify npx -p typescript tsc -p tsconfig.declaration.json

TobiTenno commented 4 years ago

@filipedeschamps if you could review real fast, this makes the lib usable on typescript-based projects a lot easier

TobiTenno commented 4 years ago

@filipedeschamps whenever you approve this, i can get it merged

TobiTenno commented 4 years ago

@abdatta if you copy my branch and put a PR in, i can approve and merge it, i just can't approve & merge them if i submit the pr

filipedeschamps commented 3 years ago

:tada: This PR is included in version 3.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: