search

filipedeschamps / rss-feed-emitter

Super RSS News Feed aggregator written in Node.js and ES6
MIT License
1.06k stars 77 forks source link

npm package request deprecated #224

Open jasperchua99 opened 2 years ago

jasperchua99 commented 2 years ago

https://github.com/request/request/issues/3142

this npm package seam to be deprecated, any reification to use another package?

TobiTenno commented 2 years ago

Sadly, the owner didn't give me sufficient perms to merge my own fixes and no one else can review my changes. So until some configuration on this repo gets fixed, I can't fix that and some other outstanding issues.

jasperchua99 commented 2 years ago

oic

filipedeschamps commented 2 years ago

You guys are right. After others projects and a recently born son my life has changed significantly. I've also published a video on my channel explaining how I screwed up with my open source projects.

But what can I do to fix this? @TobiTenno you have write access to the repo I think, maybe you can start merging things to master by yourself, you are doing an amazing job. And I saw you made a PR to start using Github Actions. What do you think to remove all external dependencies (including Coverals)? Also, let's not auto-publish do npm. I prefer doing this manually.

TobiTenno commented 2 years ago

I think admin is required to merge my own and set up better actions.

my reasoning on auto-publishing is that it keeps fixes going out quickly (and I don't have access to do so), so it would make it easier on you and I so that in the future if others are brought on to approve, they don't also need access to publish. the keys are thankfully secrets and github doesn't allow reading them after they're written, so even I would never need to know the npm token's contents

i still think this is an awesome project and I'd love to keep it going as much as I'm able. Stuff like coveralls or codeclimate are fine to me because they give an extra eye to security checks that I might not realize. there are github actions that can do some of the same, but I've not seen one for coverage as of yet.

jasperchua99 commented 2 years ago

well im all ears to hears what yall are gonna do to make sure this project goes smoothly, for now tho, request is the only one bugging my npm to change to another file

TobiTenno commented 2 years ago

Yeah, I'll get started on that migration once I finish the 2 others (config spread and dedupe)

TobiTenno commented 2 years ago

at this point, i'm gonna have to lean on y'all, cause I can't merge my own stuff still, so if y'all can submit fixes, i can merge them