search

filipwasil / fillwave

Multiplatform C++14 graphics engine
https://filipwasildev.bitbucket.io/
MIT License
23 stars 6 forks source link

Fedora port #92

Closed filipwasil closed 7 years ago

filipwasil commented 7 years ago

Last time i worked on fedora porta i had problems with dependencies.

Hopefullly the prince of Narnia will help :)

filipwasil commented 7 years ago

Make a separate script for Fedora instead od one build_linux.sh

lets say:

build_linux_rpm.sh

bulid_linux_deb.sh

or something like this

filipwasil commented 7 years ago

Do your best @revcorey :)

KeramKeram commented 7 years ago

There was some changes in catalogs? I separate rpm build but after run script first: In file included from /home/radek/programowanie/filwave/fillwave/inc/fillwave/core/buffers/IndexBuffer.h:38:0, from /home/radek/programowanie/filwave/fillwave/inc/fillwave/models/Skybox.h:39, from /home/radek/programowanie/filwave/fillwave/inc/fillwave/space/Scene.h:39, from /home/radek/programowanie/filwave/fillwave/inc/fillwave/Fillwave.h:37, from /home/radek/programowanie/filwave/fillwave/src/Fillwave.cpp:42: /home/radek/programowanie/filwave/fillwave/inc/fillwave/Assets.h:41:57: fatal error: assimp/Importer.hpp: Nie ma takiego pliku ani katalogu compilation terminated. I correct this in formatter.sh but after again next problem. In file included from /home/radek/programowanie/filwave/fillwave/inc/fillwave/core/buffers/VertexBufferBasic.h:38:0, from /home/radek/programowanie/filwave/fillwave/src/core/buffers/VertexBufferBasic.cpp:34: /home/radek/programowanie/filwave/fillwave/inc/fillwave/Assets.h:41:57: fatal error: assimp/Importer.hpp: Nie ma takiego pliku ani katalogu

KeramKeram commented 7 years ago

Only as test in platform/Linux.cmake i commented if statement now complies(but stop in 98% but problem is now different).

if(FILLWAVE_BUILD_PACK)

include_directories(${FILLWAVE_MODEL_LOADER_INCLUDES})

endif()

filipwasil commented 7 years ago

Regarding not building project when missing assimp:

/home/radek/programowanie/filwave/fillwave/inc/fillwave/Assets.h:41:57: fatal error: assimp/Importer.hpp: Nie ma takiego pliku ani katalogu

This happens when you had not installed libassimp-dev package installed on ubuntu. Fedora now has a different name for this package.

2) Regarding commented if statement - change you made, makes the project compile the internal assimp package placed under "ext/assimp". We do not want this. We want to use the system packages.

I think you did not install those:

assimp.x86_64 assimp-devel.x86_64

FILLWAVE_BUILD_PACK is used when you want to build project without system packages (It uses glm, glfw, glew, assimp and all other from ext directory.

@revcorey

KeramKeram commented 7 years ago

When I started corrected script for install package , system says I have them. I will check thislater.

filipwasil commented 7 years ago

It may be that on fedora, the missing headers are installed in some custom location (local/include instead of /include like under Ubuntu)

The point is it does not find the assimp headers. This is the real problem here. Cheers !

2016-09-27 7:54 GMT+02:00 revcorey notifications@github.com:

When I started corrected script for install package , system says I have them. I will check thislater.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/filipwasil/fillwave/issues/92#issuecomment-249772991, or mute the thread https://github.com/notifications/unsubscribe-auth/ABxGvVCFFVFrSIpQ-uri8jSAlrnRwN8zks5quK-hgaJpZM4KDODX .

Pozdrawiam serdecznie / Best Regards

Filip Wasil

filipwasil.bitbucket.org

KeramKeram commented 7 years ago

Ok, my preliminary checks indcates that: -dnf ignore assimp.x86_64 when he is on the list(with other packegs) but when you type him alone he install, -There is no glm packeg(there is devel only, i miss this last time when I checked.) Currently I'm again changing dnf packeg script. edit: It is solved I must remove glm from list. If not, script only says that, some packegs are installed or there is no packeg. That misled me last time.

filipwasil commented 7 years ago

glm is only in dev package. This is a header only library. No lib at all.

2016-09-27 19:11 GMT+02:00 revcorey notifications@github.com:

Ok, my preliminary checks indcates that: -dnf ignore assimp.x86_64 when he is on the list but when you type him alone he install, -There is no glm packeg(there is devel only, i miss this last time when I checked.) Currently I'm again changing dnf packeg script.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/filipwasil/fillwave/issues/92#issuecomment-249931914, or mute the thread https://github.com/notifications/unsubscribe-auth/ABxGvQac_Qs8o4BkbZG4P2--BMEJX0biks5quU5bgaJpZM4KDODX .

Pozdrawiam serdecznie / Best Regards

Filip Wasil

filipwasil.bitbucket.org

KeramKeram commented 7 years ago

Both rpm are generate without problem, i installed them and I see them on apper list.

Now I'm preparing second script for ubuntu and I will check him on my ubuntu virtual machine.

KeramKeram commented 7 years ago

Both scripts are on review but in my opinion there is problem with apt-get install for assimp on ubuntu, in 16.04 package have different name(I checked this on vm but this ubuntu 16.04 is not update.). Filip can you check this?

filipwasil commented 7 years ago

libassimp3v5 is the name under Ub 16.04. Just checkin' it out. give me a sec.

filipwasil commented 7 years ago

libassimp3v5 libassimp-dev

filipwasil commented 7 years ago

libassimp3 libassimp-dev on ubuntu 14.04

filipwasil commented 7 years ago

I guess Ubuntu 14.04.02 also uses libassimp3v5. :plus1: