finos / legend-engine

Legend Engine module
https://legend.finos.org
Apache License 2.0
80 stars 233 forks source link

validate tree pure constraint at runtime instead of compile time #3043

Closed keenkeystrokes closed 3 weeks ago

keenkeystrokes commented 3 weeks ago

What type of PR is this?

What does this PR do / why is it needed ?

validate dataquality tree pure constraint at runtime instead of compile time

Does this PR introduce a user-facing change?

No

github-actions[bot] commented 3 weeks ago

Test Results

  1 022 files  ±0    1 022 suites  ±0   1h 21m 58s :stopwatch: -44s 12 166 tests +1  12 076 :heavy_check_mark: +1  90 :zzz: ±0  0 :x: ±0  17 706 runs  +1  17 616 :heavy_check_mark: +1  90 :zzz: ±0  0 :x: ±0 

Results for commit f79f9a11. ± Comparison against base commit f4585d5e.

:recycle: This comment has been updated with latest results.

rafaelbey commented 3 weeks ago

What is the benefits of doing it at runtime? From a user perspective, the later the validations happen, the worse the experience, as it means they dotn get to know what is wrong likely until the are commiting code.

keenkeystrokes commented 3 weeks ago

Makes sense to validate at compile time only. Hence closing the request