search

finos / legend-engine

Legend Engine module
https://legend.finos.org
Apache License 2.0
80 stars 233 forks source link

Concatenate grouping filter fix #3053

Closed gs-saurabh closed 3 weeks ago

gs-saurabh commented 3 weeks ago

What type of PR is this?

What does this PR do / why is it needed ?

This PR will remove unwanted 'having' clause in 'UNINON ALL' sql query generated using concatenation operation. This was only happening when 'filter' is used post 'groupBy' clause in concatenation.

Does this PR introduce a user-facing change?

NA

github-actions[bot] commented 3 weeks ago

Test Results

  1 026 files  ±0    1 026 suites  ±0   1h 27m 3s :stopwatch: +36s 12 182 tests +4  12 092 :heavy_check_mark: +4  90 :zzz: ±0  0 :x: ±0  17 719 runs  +4  17 629 :heavy_check_mark: +4  90 :zzz: ±0  0 :x: ±0 

Results for commit baa19725. ± Comparison against base commit 74ef33f2.