search

finos / legend-engine

Legend Engine module
https://legend.finos.org
Apache License 2.0
83 stars 235 forks source link

Persistence Component: Fix schema evolution for bitemp temp tables #3090

Closed kumuwu closed 1 month ago

kumuwu commented 1 month ago

What type of PR is this?

What does this PR do / why is it needed ?

Schema evolution was not working for bitemporal delta (source specifies from only), as temp tables got created with old schema. Fixed by correcting the sequence of SQL generation (schema evolution first).

Which issue(s) this PR fixes:

Fixes #

Other notes for reviewers:

Does this PR introduce a user-facing change?

github-actions[bot] commented 1 month ago

Test Results

  1 033 files  ±0    1 033 suites  ±0   1h 27m 0s :stopwatch: + 1m 28s 12 261 tests +3  12 171 :heavy_check_mark: +3  90 :zzz: ±0  0 :x: ±0  17 940 runs  +3  17 850 :heavy_check_mark: +3  90 :zzz: ±0  0 :x: ±0 

Results for commit a0ed9c6a. ± Comparison against base commit 8ddd43b7.