search

fisshy / react-scroll

React scroll component
https://github.com/fisshy/react-scroll/blob/master/README.md
MIT License
4.36k stars 437 forks source link

Replace unsafe componentWillReceiveProps with componentDidUpdate #370

Open aakula-edmunds opened 5 years ago

aakula-edmunds commented 5 years ago

Replace unsafe componentWillReceiveProps with componentDidUpdate so as not to generate strict mode warnings

milonite commented 5 years ago

Currently there's a warning due componentWillReceiveProps, do you plan to merge this pr?