search

fisshy / react-scroll

React scroll component
https://github.com/fisshy/react-scroll/blob/master/README.md
MIT License
4.36k stars 437 forks source link

scrolling offset with container is broken after 1.7.7 #379

Open madmed88 opened 5 years ago

madmed88 commented 5 years ago

a workaround is to set the offset to -containerTopPosition which is not ideal if this value is dynamic. or to downgrade to 1.7.7

fisshy commented 5 years ago

Thanks for the issue, will look into it.

joakimc commented 5 years ago

I have the same issue. Is it a bug, or how it's supposed to work?

Edit: Turns out the container element needs position: relative

Badbreaddead commented 5 years ago

This should be in docs!