search

fisshy / react-scroll

React scroll component
https://github.com/fisshy/react-scroll/blob/master/README.md
MIT License
4.36k stars 437 forks source link

react should be in "dependencies" not "devDependencies" in package.json #412

Closed sethomas closed 4 years ago

sethomas commented 4 years ago

For lines like this: https://github.com/fisshy/react-scroll/blob/master/modules/components/Link.js#L3

React is required at run time, can you move "react" from devDependencies to dependencies in package.json?

fisshy commented 4 years ago

Make a PR! :)

sethomas commented 4 years ago

@fisshy https://github.com/fisshy/react-scroll/pull/414 thanks for response!