Element component is using div with attribute name, and is not valid for w3c to validate html5

fisshy / react-scroll

React scroll component

https://github.com/fisshy/react-scroll/blob/master/README.md

MIT License

4.36k stars 437 forks source link

Element component is using div with attribute name, and is not valid for w3c to validate html5 #417

Open mirai-wordpress opened 4 years ago

mirai-wordpress commented 4 years ago

Element component is using a tag div with an attribute name. Name is not an attribute for tag 'div' and is not valid for w3c to validate html5. Is better to use data-name or something like that and then the component will pass de accesibility test.

thisispaul commented 4 years ago

@mirai-wordpress you can use id instead of name and it will still work + pass accessibility.