search

fisshy / react-scroll

React scroll component
https://github.com/fisshy/react-scroll/blob/master/README.md
MIT License
4.36k stars 437 forks source link

Horizontal scroll support #429

Closed yoiang closed 4 years ago

fisshy commented 4 years ago

Thanks for the PR, probably useful for many.

Missing tests in the PR.

yoiang commented 4 years ago

Ah good call, my bad! I'll add them now.

Are you currently running with all tests completing? Even in the react-scroll master I'm getting the following three tests failing:

Events ✖ calls "end" event on scrollTo Firefox 57.0.0 (Mac OS X 10.15.0) Error: Expected 2259 to equal 100 (webpack:///~/expect/lib/assert.js:29:0 <- tests.webpack.js:10760)

Page ✖ is active when clicked Firefox 57.0.0 (Mac OS X 10.15.0) Error: Expected 1217 to equal 2259 (webpack:///~/expect/lib/assert.js:29:0 <- tests.webpack.js:10760)

✖ is active when clicked to last (5) element Firefox 57.0.0 (Mac OS X 10.15.0) Error: Expected 100 to equal 5427 (webpack:///~/expect/lib/assert.js:29:0 <- tests.webpack.js:10760)

yoiang commented 4 years ago

Nix that, it seems like refreshing the open Karma connected browsers results in those tests passing!

dav92lee commented 4 years ago

@yoiang thank you so much!!! i need this desperately for my project.

dav92lee commented 4 years ago

@fisshy could we possibly get this merged and shipped ?

fisshy commented 4 years ago

@dav92lee Yes, most likely, just recieved the changes I've been waiting for.

Tests are important :)

fisshy commented 4 years ago

@yoiang Was going to merge this, but the new tests are not passing for me.

yoiang commented 4 years ago

@fisshy all are failing or two as mentioned in the commit? I still need to set aside time to sit down and see what's up with those two!

To that end we should get PRs' tests run on a CI so we can all see ;)

softage0 commented 4 years ago

Any update on this? I'm so waiting for this :)

fisshy commented 4 years ago

@softage0 waiting on @yoiang to fix the tests, so all passes.

yoiang commented 4 years ago

@fisshy @dav92lee @softage0 sorry, trying to make time! help taking this PR over the finish line is of course welcome ;)

dav92lee commented 4 years ago

@yoiang swamped myself -- promise to give it a try next weekend when I have some time. Thanks for your work!

softage0 commented 4 years ago

@yoiang I just sent PR to fix test cases and add several missing features: https://github.com/Adorkable-forkable/react-scroll/pull/1

Please review this :)

yoiang commented 4 years ago

Merged in @softage0 great work! I was getting it to pass sometimes, fail sometimes locally, would anyone have insight into that or is the passing enough?

edwinlimlx commented 4 years ago

Nice work guys! any chance this will be release soon?

fisshy commented 4 years ago

I have now released it as v1.8.0 :)

LeoAmeneiros commented 4 years ago

Thanks for the release! can you add how to use this new feature it in the docs?