search

fisshy / react-scroll

React scroll component
https://github.com/fisshy/react-scroll/blob/master/README.md
MIT License
4.36k stars 437 forks source link

chore: update Gulp to version 4 #446

Closed jpedroschmitz closed 4 years ago

jpedroschmitz commented 4 years ago

Hey, this PR updates Gulp to version 4, fixing the following error when running npm run build.

...
modules/mixins/utils.js -> build/npm/modules/mixins/utils.js
fs.js:36
} = primordials;
^

ReferenceError: primordials is not defined
at fs.js:36:5

This error occurs due to Node.js 12 (or above) and Gulp 3. For more info, check this Stack Overflow question.

After upgrading to Gulp 4, the error was fixed, and the build has run successfully.

fisshy commented 4 years ago

Great!