Element's name attribute

fisshy / react-scroll

React scroll component

https://github.com/fisshy/react-scroll/blob/master/README.md

MIT License

4.35k stars 436 forks source link

Element's name attribute #538

Closed 0xdeadc0d3 closed 1 year ago

0xdeadc0d3 commented 1 year ago

Consider removing the name attribute from the Element component because in HTML5, the div element should not have a name attribute. Also, as an alternative to removing this attribute, I propose to make it optional in the @types/react-scroll package

fisshy commented 1 year ago

Feel free to make a PR! :)