fisshy / react-scroll

React scroll component
https://github.com/fisshy/react-scroll/blob/master/README.md
MIT License
4.35k stars 436 forks source link

Modernize README Examples and Convert Components to Functional #511 #564

Closed Danguya closed 1 year ago

Danguya commented 1 year ago

Description:

This Pull Request encompasses a series of enhancements aimed at improving the codebase and documentation of our project. The key modifications include the conversion of class components to functional components, utilizing the latest features and best practices in React development. Additionally, the README file has been updated to reflect these changes, providing users and contributors with more accurate and up-to-date examples.

Main Changes:

Goals:

Testing:

This PR contributes to the ongoing effort to improve the project's quality and usability, and feedback on these changes is highly appreciated.

This PR is a response to issue #511 and seeks to address the points raised in it, bringing significant improvements to both the code and the project documentation. I appreciate any feedback in advance and am open to discussions and adjustments to ensure that the changes meet the project's needs in the best possible way.

fisshy commented 1 year ago

Thanks alot, will merge it.