fivetran / dbt_facebook_ads

Fivetran data models for Facebook Ads built using dbt.
https://fivetran.github.io/dbt_facebook_ads/
Apache License 2.0
27 stars 27 forks source link

New feature: Unioning source data #13

Closed pawelngei closed 2 years ago

pawelngei commented 3 years ago

Are you a current Fivetran customer? Yes, Pawel Ngei, Pattern Brands

What change(s) does this PR introduce?

Does this PR introduce a breaking change?

Is this PR in response to a previously created Issue

How did you test the PR changes?

Pattern Brands data, two datasets from Facebook Ads connector with Snowflake.

IMPORTANT: Our data didn't generate anything in the stg_facebook_ads__app_link model, you might want to test it on another dataset.

Select which warehouse(s) were used to test the PR

:building_construction:

Feedback

Added info about the basic_ad report to this plugin's Readme, as a lot of your potential users might not look at the source plugin (which doesn't need to be installed separately).

Needs new auto-generated docs and the packages.yml change once the _source and _creative_history plugins are published. Added a basic Changelog, you might want to build on it.

fivetran-joemarkiewicz commented 2 years ago

Thanks again so much for putting the effort into this PR @pawelngei! There are a few minor changes (tests and formatting updates) that I am going to apply before we include this in a live version of the package. Therefore I am changing the base branch to be a working branch that I will apply these updates to.

Thanks so much!