[Feature] Update to use `fivetran_utils.extract_url_parameter` instead of `dbt_utils.get_url_parameter`

fivetran / dbt_facebook_ads

Fivetran data models for Facebook Ads built using dbt.

https://fivetran.github.io/dbt_facebook_ads/

Apache License 2.0

24 stars 27 forks source link

[Feature] Update to use `fivetran_utils.extract_url_parameter` instead of `dbt_utils.get_url_parameter` #37

Open fivetran-catfritz opened 7 months ago

fivetran-catfritz commented 7 months ago

Is there an existing feature request for this?

[X] I have searched the existing issues

Describe the Feature

An issue with dbt_utils.get_url_parameter was discovered in https://github.com/fivetran/dbt_linkedin_source/issues/55 for Databricks SQL. Macro fivetran_utils.extract_url_parameter was added to solve this issue for Databricks targets (see https://github.com/fivetran/dbt_fivetran_utils/pull/130 more info).

For this package, references to dbt_utils.get_url_parameter need to be updated to fivetran_utils.extract_url_parameter.

fivetran-joemarkiewicz commented 7 months ago

The latest release of this package has been updated to use the custom facebok_ads_source.extract_url_parameter() macro. This addresses the immediate issue raised in this feature request. However, in the next breaking change of this package we will want to remove the custom macro and swap the package to leverage the fivetran_utils.extract_url_parameter() macro.

This was not implemented originally as it could possibly have caused breaking changes, we wanted to address the issue in a timely manner while ensuring we did not break any transformation pipelines.