Open fivetran-jamie opened 3 months ago
@fivetran-jamie @fivetran-joemarkiewicz Now might be a good time to delete the defunct 2nd reviewer bot.
@fivetran-jamie @fivetran-joemarkiewicz Now might be a good time to delete the defunct 2nd reviewer bot.
Agreed! @fivetran-jamie would you be able to remove that from this branch.
Great effort! Looking forward to this release.
PR Overview
This PR will address the following Issue/Feature: no issue made
This PR will result in the following new package version:
v0.8.0
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Feature Updates
Introducing...conversion metrics (PR #43)!
conversion_value
field to each_report
end model, representing the value of conversions (calculated using the default attribution window set in Meta) that occurred on each day for each ad/campaign/ad set/url/account.facebook_ads__basic_ad_actions_passthrough_metrics
variable to pass through additional conversion value metrics that are calculated using different attribution windows.Documentation
facebook_ads__basic_ad_passthrough_metrics
variable. See README for details (PR #43).Under the Hood
quickstart.yml
file to allow for automated Quickstart data model deployments (PR #40).PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Tests are passing
conversion_value
from each_report
end modelclicks
,impressions
, andspend
across dev and prod in each of the_report
modelsNo exceptions needed, just a teeny tiny buffer to account for differences in rounding