fivetran / dbt_facebook_ads

Fivetran data models for Facebook Ads built using dbt.
https://fivetran.github.io/dbt_facebook_ads/
Apache License 2.0
27 stars 27 forks source link

Feature/add conversions #43

Open fivetran-jamie opened 5 months ago

fivetran-jamie commented 5 months ago

PR Overview

This PR will address the following Issue/Feature: no issue made

This PR will result in the following new package version:

v0.8.0

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Feature Updates

Introducing...conversion metrics (PR #43)!

Documentation

Under the Hood

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

Detailed Validation

Please share any and all of your validation steps:

Tests are passing image

  1. Horizontal integrity test compares total sum of conversion_value from each _report end model
  2. Consistency tests compare clicks, impressions, and spend across dev and prod in each of the _report models

No exceptions needed, just a teeny tiny buffer to account for differences in rounding image

fivetran-catfritz commented 5 months ago

@fivetran-jamie @fivetran-joemarkiewicz Now might be a good time to delete the defunct 2nd reviewer bot.

fivetran-joemarkiewicz commented 5 months ago

@fivetran-jamie @fivetran-joemarkiewicz Now might be a good time to delete the defunct 2nd reviewer bot.

Agreed! @fivetran-jamie would you be able to remove that from this branch.

maxtuzz commented 5 months ago

Great effort! Looking forward to this release.

fivetran-jamie commented 1 month ago

FYI for anyone subscribed here, this is currently blocked.

We are working with Engineering to ensure that the conversion monetary values (action_values) are included in a default report and therefore accessible to the package (currently, only the raw # of conversions are supported by the basic_ad_actions report).