User Auth

[gorterd]

Nice work Francis! Love the custom slack images and icon! Below is my feedback

Functionality

• [x] make the logos links on splash
• [x] we already talked about this, but make sure the homepage is not an auth route (and thus in the upper right, when logged in, you should have a Launch Slack button, like in the real slack --> that can just take you to the user's default channel instead of what slack does though)
• [x] errors from signing up appear on the login form and vice versa. either store sign up and login errors under separate keys in your state, or clear your errors somewhere (I'd advise dispatching an action to clear errors in componentWillUnmount for your session forms)
• optional / bonus for session forms: use html email validations as in the real slack https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/email#Validation

Styling

• Splash
  • [x] add hover effect to buttons (cursor should look like pointer, color should darken)
  • [x] make the navbar a bit taller (so there's more space above and below the buttons / logo in the navbar)
  • [x] Sign in should look like it does on slack (just a link instead of a button)
  • Quick optional fix: I'd suggest giving a bit of space below the second splash image so the white background in the image isn't flush with the footer.
• Session Forms
  • [x] make the button submission button a little shorter
  • [x] add more space above the logo at the top of the page
  • [x] render the errors above the submission button
  • [x] change the type on your password input so that it appears as dots and not text

[gorterd]

Excellent work, Francis!

Here's my feedback:

• [x] After logging in as the demo user, you should be redirected to the user's default channel
• [x] on the sign up page, multiple error messages (when, for example, I leave everything blank), all appear on the same line --> they should probably be broken down into separate lines
  • [x] relatedly, I noticed a 'username can't be blank' error even though there is no username field in the sign up form. if you derive your username from the email address on the backend, no need for a presence validation for username if you have one for email address.

A couple quick things I missed first time around, they should collectively take <15 min, if it doesn't seem like an easy fix, don't worry about it:

• [x] type in 'email address' in your session forms (needs 2 d's)
• [x] I'd suggest centering the splash text boxes vertically, relative to the image they are next to, and making them slightly more narrow (like Slack)
• [x] I'd suggest adding more padding/margin to the right / left of the splash content (images & text), as well as to the logo in the navbar
• [x] I'd suggest spacing out the footer lists slightly more
• [x] looks like you have a 'hello from dispatch' console log still in your code :)
• Optional: you could fill out the navbar a bit with links to your own personal sites (github, linkedin etc) (where the 'Why Slack?', 'Solutions', etc links appear on Slack)

[gorterd]

Hey Francis -- awesome work!

Just wanted to add two things:

• [x] Only noticed this now, as I'm not reviewing this on an external monitor, but I'd suggest reducing the size of the second image on the splash. It's causing the width of the page's content to be wider than my window, full screen.
• [x] Demo button is still not redirecting me, for some reason (while I'm successfully logging in, I keep thinking that it's not working since nothing seems to change when I click it).