Channels - Githubissues

Great work, Francis -- keep it up! Here's my feedback for the channels MVP:

Functionality

[x] I'd recommend removing any options from the upper right dropdown that involve features you don't plan to implement this week. (Perhaps all but log out?)
[x] Clicking the Channels collapse/expand button in the sidebar should show and hide all channels (the default channel always shows for me), and should default to open
[x] Got this when clicking on a channel in the sidebar, sometimes
[x] Get this upon refresh of channel show page, sometimes
[x] Adding members to a channel should replicate the experience on Slack: it should be a modal form with a search box. (I have some styling comments as well, but will wait for you to refactor it into modal, since the design will probably change).
[x] Clicking on the members number / icons in the upper right of a channel should bring up a modal like Slack's, with a header, link to add people, and a list of the members with a button in each list item to remove them; I'd say the search bar is a bonus / stretch.
[x] A user should automatically be a member of any channel they create (so that channel would appear in the sidebar as soon as they create it)
[x] When you click to join a channel in the channel browser, the join button should become a Leave button, like on Slack
[x] As soon as you join a channel, it should appear in the sidebar --> you might want to think about how the RECEIVE_MEMBERSHIP action might be listened to by the user / channel reducers.
[x] A user should not be able to join a channel they are already a part of.
Bonus / stretch: Add a search bar to your channel browser

Styling

[x] The upper right user dropdown needs to look closer to Slacks --> name in bold and icon at top, more spaced out, some space between the dropdown and the right edge of the screen, drop-shadow, border radius, text turns white while its list item is hovered over, etc
[x] Sidebar and channel area should extend to the bottom of a page (and if there's only a few messages, those should appear at the bottom).
[x] I think it's fine that you made the info button in the upper right of a channel open up a dropdown instead of a whole side panel (since you won't be implementing most of those features). However, I'd style that dropdown more nicely (as with the upper right user dropdown), and would consider implementing the side panel as a bonus.
[x] channels in sidebar should be more spaced out and should get a hover effect like Slack's
[x] the little triangle in the Channels collapse / expand button should rotate depending on whether the channels index is expanded or collapsed, and should have a hover effect like Slack's
[x] the Channels + dropdown (browse channels, create a channel), should hide when you click outside it or click one of its options
[x] The members # and Add member buttons in the upper right of a channel need hover effects like Slack's
[x] I'd add more padding to the Create button in the Create Channel modal, as well as make sure the Create button, toggle, and input fields extend to the right side of the modal.
[x] Browse Channels page should have a header that says Channel browser and has a Create Channel button in the right.
[x] Channels in channel browser should only show join button upon hover
Optional / bonus: center icons within their hover effect container (e.g. the plus button for creating a channel appears in the top of the light grey box behind it, upon hover)
Optional / bonus: show up to three icons of the members of a channel in the upper right of a channel

Hey Francis, I know channels is a very sizable MVP, so nice work addressing all these various odds and ends! The join/leave functionality in the channel browser is working great! There are still some bugs and styling issues I noticed. I know it's the last night, so just address what you can, and most of this can be a record for the future. I marked optional whatever I think is especially minor / not urgent.

Functionality

[ ] onBlur for your channel info dropdown is not working for me
[x] the order of the channels in the sidebar should remain consistent. Right now, when I navigate to another channel, it jumps to the top of the channels list (consider
[x] when I remove a member from a channel inside the modal, they should disappear from the list of members
[x] the current user doesn't appear in the list of group members inside the modal, but they should (otherwise it'll say one member, but be blank, which looks a little off)
[x] inside the channel members modal, when I'm searching for users to add to a channel, I'm getting this every time I type (almost like it's triggered by the onChange)
[x] I get this whenever I open the channel member modal
[x] Getting this when I edit a channel (right after clicking the edit button).
[x] When I delete a channel, I stay on that channel's show. I'd suggest redirecting upon deleting a channel
Optional: Does the 'private' toggle do anything? I love the styling, but you may consider removing it for now.

Styling

[ ] when I click to add a member to a channel, nothing visually happens. On slack, the results disappear and the below happens. Implementing it this way would definitely be a bonus. But I think at least the search results should disappear or some other form of confirmation that the user got added.
[ ] When I go to the edit page of a channel, another channel becomes highlighted in the sidebar
Optional / Later: in the real Slack, the channel description is tucked inside the About in the info side panel. Since you don't have that, it would be nice to see the description somewhere, perhaps below the name of the channel in the channel header / details?
Optional / Later: right now, the triangle icon to the left of 'Channels' in the sidebar receives hover effect whenever I hover over any part of the channels index
Optional / Later: the channels in the channels browser shouldn't get bigger as I hover over them

fjswayze / Shack

Channels #4

Functionality

Styling