codders
commented
1 year ago That makes sense to me. We should definitely delete the crawl_ prefix at the same time.
Thank you!
Arthur
Johannes Velde @.***> schrieb am Di., 4. Apr. 2023, 08:22:
Hey i thought we could move the crawlers into a seperate folder for more strucutre of the code. What do you think?
something like this:
├── CODE_OF_CONDUCT.de.md ├── [...] ├── flathunt.py ├── flathunter │ ├── [...] │ ├── captcha │ | ├── [...]
│ ├── crawler (New folder inside flathunter folder) │ | ├── crawl_ebaykleinanzeigen.py │ | ├── crawl_idealista.py │ | ├── crawl_immobiliare.py │ | ├── crawl_immobilienscout.py │ | ├── crawl_immowelt.py │ | ├── crawl_wggesucht.py │ | ├── crawler_subito.py
│ ├── chrome_wrapper.py │ ├── config.py //moved to /crawler │ ├── crawl_ebaykleinanzeigen.py │ ├── crawl_idealista.py │ ├── crawl_immobiliare.py │ ├── crawl_immobilienscout.py │ ├── crawl_immowelt.py │ ├── crawl_wggesucht.py │ ├── crawler_subito.py │ ├── default_processors.py │ ├── exceptions.py │ ├── filter.py │ ├──[...] │ ├── sender_apprise.py │ ├── sender_mattermost.py │ ├── sender_telegram.py │ ├── string_utils.py │ ├── time_utils.py
also we could end up with deleting the prefix 'crawl_' because we already know that they are crawlers
if you like this idea, i can open a PR for this.
— Reply to this email directly, view it on GitHub https://github.com/flathunters/flathunter/issues/355, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAEK5TVPTLXJQUXXEFJBT3W7O43ZANCNFSM6AAAAAAWSHWKJI . You are receiving this because you are subscribed to this thread.Message ID: @.***>
veldhaenchen
Hey i thought we could move the crawlers into a seperate folder for more strucutre of the code. What do you think?
something like this:
├── CODE_OF_CONDUCT.de.md ├── [...] ├── flathunt.py ├── flathunter │ ├── [...] │ ├── captcha │ | ├── [...]
│ ├── crawler (New folder inside flathunter folder) │ | ├── crawl_ebaykleinanzeigen.py │ | ├── crawl_idealista.py │ | ├── crawl_immobiliare.py │ | ├── crawl_immobilienscout.py │ | ├── crawl_immowelt.py │ | ├── crawl_wggesucht.py │ | ├── crawler_subito.py
│ ├── chrome_wrapper.py │ ├── config.py //moved to /crawler ~~│ ├── crawl_ebaykleinanzeigen.py │ ├── crawl_idealista.py │ ├── crawl_immobiliare.py │ ├── crawl_immobilienscout.py │ ├── crawl_immowelt.py │ ├── crawl_wggesucht.py │ ├── crawler_subito.py~~ │ ├── default_processors.py │ ├── exceptions.py │ ├── filter.py │ ├──[...] │ ├── sender_apprise.py │ ├── sender_mattermost.py │ ├── sender_telegram.py │ ├── string_utils.py │ ├── time_utils.py
also we could end up with deleting the prefix 'crawl_' because we already know that they are crawlers
if you like this idea, i can open a PR for this.