search

flathunters / flathunter

A bot to help people with their rental real-estate search. 🏠🤖
GNU Affero General Public License v3.0
831 stars 179 forks source link

Replace Google Chrome with Chromium in Dockerfile #533

Closed Alexandero89 closed 6 months ago

Alexandero89 commented 6 months ago

Hey all,

is there a special reason Google Chrome is used in the Dockerfile instead of Chromium? ( see here ) Maybe because of detection reasons or something? Otherwise i would create a PR to replace the proprietary Google Chrome with Chromium (which has almost the same features, but no tracking and google stuff).

I think @alexanderroidl implemented this and could maybe say something?

codders commented 6 months ago

From my side no particular reason. I would be happy to switch to Chromium - I haven't had any reports that Chromium works worse than Chrome. We could even see if Firefox does what we need - it's never been a better time to switch to Firefox.

Alexandero89 commented 6 months ago

Good point. Will also check if Firefox will be able to replace Chrome.

I hope the tests are good enough to catch all errors, because i think i dont know the tool good enough to see all the edge cases where this swap could fail or produce errors.

codders commented 6 months ago

Awesome - thank you! The test coverage is pretty good, except that the selenium integration tests don't run for PRs because of permissions issues. So if the tests pass for you locally and crawling immoscout with Firefox works, then we can try it and see if the tests still pass after merge.

codders commented 6 months ago

Ah. One thing. For Chrome we have undetected_chromedriver, which is important for bot detection. I don't know if there's something similar for Firefox

Alexandero89 commented 6 months ago

As far as i see there is nothing like undetected-geckodriver ( see here ) I only found a preference to turn off ( see) but i dont know if this would be enough and would reach the same scope of undetected_chromedriver.

So for now i would just replace chrome with chromium and do some research before later on maybe replace it to firefox.

codders commented 6 months ago

makes sense. Thanks for the research