Closed sfohr closed 7 months ago
Closes #19.
Collection of small improvements for the changes introduced with #13: docstrings, typos and additional tests.
This PR introduces the following changes:
post_momentum_X = apply_momentum(X, X_previous, beta=0.0)
beta=1.0
model_free_util.py
test_instantiate_kernel_honors_strategy_selection
Momentum3BlockModelFreeKernel
test_factory_util.py
apply_momentum
beta=0.0
test_model_free_util.py
W0
H0
low_rank_candidate_L
test_momentum_three_block_model_free_kernel.py
Individual commits follow the order in #19 - one commit for one list item.
All looks good; merged.
Closes #19.
Type of change
Motivation and Context
Collection of small improvements for the changes introduced with #13: docstrings, typos and additional tests.
Description
This PR introduces the following changes:
Most likely will not be expanded, even as other naive kernels are added."post_momentum_X = apply_momentum(X, X_previous, beta=0.0)
instead ofbeta=1.0
model_free_util.py
test_instantiate_kernel_honors_strategy_selection
to also testMomentum3BlockModelFreeKernel
test_factory_util.py
apply_momentum
:beta=1.0
, which doubles the 'step' taken from the previous to the current iterationbeta=0.0
, which just returns the current matrix without altering ittest_model_free_util.py
Momentum3BlockModelFreeKernel
:W0
is given butH0
is notW0
is not given butH0
isW0
andH0
will be reinstantiated using SVD onlow_rank_candidate_L
test_momentum_three_block_model_free_kernel.py
How to Review
Individual commits follow the order in #19 - one commit for one list item.
Checklist