fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.01k stars 418 forks source link

Update `fleetctl apply` to support new bootstrap package #10933

Closed lukeheath closed 1 year ago

lukeheath commented 1 year ago

CLI

Update config YAML file

Example config YAML file:

apiVersion: v1
kind: config
spec:
  mdm:
    macos_setup:
      bootstrap_package: https://s3.amazon/folderX/dsdfkasdjfsfad/mypackage
  ...

Empty

Errors

User added bootstrap package in UI

Update team YAML file

Example team YAML file:

apiVersion: v1
kind: team
spec:
  team:
    name: Workstations
    mdm:
      macos_setup:
        bootstrap_package: https://s3.amazon/folderX/dsdfkasdjfsfad/mypackage
    ...
lukeheath commented 1 year ago

Hey team! Please add your planning poker estimate with Zenhub @mna @roperzh @gillespi314

roperzh commented 1 year ago

@noahtalerman sanity check (probably a nitpick): does it make sense to say "Couldn’t upload." in the errors? In the UI that's intuitive, but here we're not uploading the package.

noahtalerman commented 1 year ago

@roperzh agreed! We should update that error message. Good catch.

What about this?

Couldn’t edit bootstrap_package...

I think this language is what we use for custom_settings (configuration profiles) errors.

roperzh commented 1 year ago

That looks great, thanks!

fleet-release commented 1 year ago

Cloud city package, Fleetctl apply update, Signed, secure, and smooth.