fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.1k stars 427 forks source link

Add hardware serial number to vulnerability and policy webhooks/tickets #11664

Open zhumo opened 1 year ago

zhumo commented 1 year ago

This issue's remaining effort can be completed in ≤1 sprint. It will be valuable even if nothing else ships.

It is planned and ready to implement. It is on the proper kanban board.

Goal

User story
As a Fleet admin,
I want to identify a host via its serial number
so that I can be reasonably confident I am identifying a unique host.

Changes

This issue's estimation includes completing:

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

Context

zayhanlon commented 1 year ago

Hey @zayhanlon @ksatter. We're deprioritizing this issue as we won't be able to deliver it in the next 6 weeks. Please bring this back to the PFR call if it surfaces again so we can re-prioritize

noahtalerman commented 1 year ago

Zay: Medium/high priority

noahtalerman commented 1 year ago

Feature fest:

In the vulnerability and policy webhooks and ticket integrations, include the serial number of the host

Does the customer use webhooks? Are we getting this issue mixed up w/ the previous solution in this issue? #12889

nonpunctual commented 6 months ago

@noahtalerman reading through this... 1st comment says it's planned & ready. Still the case? Have other features superseded or replaced it?

I think having it as an host identifier option would be valuable.

noahtalerman commented 6 months ago

Hey @nonpunctual the issue isn't currently being worked on. It has neither the :product (design sprint) nor :release (engineering sprint) label.

Let's chat about it during feature fest.

noahtalerman commented 6 months ago

In the vulnerability and policy webhooks and ticket integrations, include the serial number of the host

@nonpunctual is this the request?

Looking at the user story in the activity feed, I don't know what problem the customer(s) is having.

nonpunctual commented 6 months ago

@noahtalerman I take everything in Github at face value I guess. If the ticket says that at some point this work was planned & ready to implement I assume that's true. I guess if you are saying that you don't even understand the user story, that must not be the case?

The problem is that some orgs would like to use serial number as the Host identifier in Fleet.

This is on top of the fact that there is (I think) a lot of confusion in the docs & in the product regarding "hostname" vs. host identifier. If I am confused by this, I believe it's reasonable to assume customers are too.

To me, what host identifier means is: the string that uniquely identifies a host in the database. Seems like serial number would be a useful options for this in many orgs.

noahtalerman commented 6 months ago

some orgs would like to use serial number as the Host identifier in Fleet.

@nonpunctual got it. What's the workflow? Are they trying to get a host via API using the host's serial? If so, this is possible w/ the Get host by identifier API endpoint.

To prioritize an improvement we have to understand the workflow.

I don't remember what workflow this issue covers (the issue is coming up on 1 year old):

nonpunctual commented 6 months ago

Thanks @noahtalerman is this currently true?

"vulnerability and policy webhooks and ticket integrations include the serial number of the host"?

I think that maybe it's not without adding decorators that include a query for serial number to write to logging.