fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
2.97k stars 413 forks source link

Fleet UI: Hosts table scrollbar issues #11753

Closed rachaelshaw closed 10 months ago

rachaelshaw commented 1 year ago

🧑‍💻  Expected behavior

💥  Actual behavior

Ever-present scrollbar when there are only a few columns:
Screenshot 2023-05-17 at 5 11 33 PM
Showing certain columns with tooltips can cause a vertical scrollbar to appear:
Screenshot 2023-05-17 at 6 06 51 PM

👣 Reproduction steps

More info

xpkoala commented 1 year ago

Hrmm, I was able to confirm the vertical scroll appearing after hovering over the MDM tooltip, but I haven't had luck reproducing the horizontal scroll issue.

Sending to CX to:

rachaelshaw commented 1 year ago

@xpkoala I'm not seeing the horizontal scrollbar anymore either, may have been fixed as a side effect of some other change

RachelElysia commented 1 year ago

This vertical scroll bar bug needs to be tabled (pun intended) or have a dirty fix (make the tooltips 2 lines). The issue is that react-table doesn't play nicely with react-tooltip. React tooltip is a component nested into a table cell and can't be styled to be in front of the table so there's no scroll. No matter what I do, it stays within .data-table table

fleet-release commented 10 months ago

Scrollbar fixed, a smooth view, Like a cloud city, clear and new. Fleet's hosts table, ever true.