fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
2.7k stars 384 forks source link

Separate file size options for query results vs. agent logs when using filesystem storage #11999

Open zhumo opened 1 year ago

zhumo commented 1 year ago

Goal

User story
As an endpoint operator,
I want to separate the retention settings for query results and status logs
so that I can compress result logs and not compress status logs.

✅ Choose different file sizes for automated query results and agent logs.

Context

Changes

Product

Engineering

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

Manual testing steps

  1. Step 1
  2. Step 2
  3. Step 3

Testing notes

Confirmation

  1. [ ] Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. [ ] QA (@____): Added comment to user story confirming successful completion of QA.
zayhanlon commented 1 year ago

Hey @ksatter , we’re de-prioritizing this issue because it’s not likely to be worked on in the next 6 weeks. Please feel free to bring it back in a future product feature requests meeting. Can you please remember to surface this at PFR again in like 6 weeks so we remember to bring it back on the board?

noahtalerman commented 9 months ago

Zay: #2 on the list

noahtalerman commented 8 months ago

Feature fest: Let's take this as an airguitar.

noahtalerman commented 7 months ago

TODO: Bring this into the next design sprint (kicks off ~Dec 15)

noahtalerman commented 7 months ago

From the customer:

  1. Relevant config settings
    1. FLEET_FILESYSTEM_MAX_SIZE
    2. FLEET_FILESYSTEM_MAX_AGE
    3. FLEET_FILESYSTEM_MAX_BACKUPS
    4. FLEET_FILESYSTEM_ENABLE_LOG_COMPRESSION
  2. Update these to have a log version and a results version
  3. What to do about backwards compatibility? Potential solution: The existing options remain applying to both, but the new more-specific set of options would override the old general option.
noahtalerman commented 6 months ago

@zayhanlon heads up, this didn't make the 3 week drafting timeline so we're removing it from the drafting board. Bringing back to feature fest.

noahtalerman commented 6 months ago

Gong call w/ the customer: https://us-65885.app.gong.io/call?id=2408209438823448017

At some point during this call we chatted about what they expect to use this feature for.

cc @rachaelshaw

noahtalerman commented 6 months ago

Noah: What’s happening today?

Customer: Neither are compressed. Which means we added a lot of hard drive space and complex infra on our Fleet instances. Result logs take up most of the space.

Customer:

Noah: Why not compress agent logs too?

Customer:

noahtalerman commented 5 months ago

@pintomi1989 heads up, we didn't get to this feature request in the current design sprint.

Bringing to feature fest.

ksatter commented 4 months ago

@nonpunctual, bringing this request back.

ksatter commented 4 months ago

@nonpunctual belay that, I didn't look closely enough.

nonpunctual commented 4 months ago

Okiedokie. 🥇