search

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.13k stars 432 forks source link

Built-in Linux labels for as many operating systems as possible #1203

Open macEar opened 3 years ago

macEar commented 3 years ago

Goal

As a new Fleet user managing Linux machines, I want built-in Linux labels for as many operating systems as possible out of the box so that I know how many machines have each operating system installed.

Workaround

Create custom Debian Linux, SLES Linux, and Kali Linux labels. To do this in the Fleet UI, head to Hosts > Add label. Then use one of the below queries to create a Debian Linux, SLES Linux, and Kali Linux label respectively.

Debian Linux:

SELECT 1 FROM os_version WHERE platform = 'debian'

SLES Linux:

SELECT 1 FROM os_version WHERE platform = 'sles'

Kali Linux:

SELECT 1 FROM os_version WHERE platform = 'kali'
macEar commented 3 years ago

Also the same problem relates to Home Dashboard of Fleet (/home/dashboard) where total Linux hosts number is wrong as it does not take into account the operating systems I mentioned here (debian, sles, kali).

macEar commented 2 years ago

@martavis no progress yet?

noahtalerman commented 2 years ago

total Linux hosts number is wrong as it does not take into account the operating systems I mentioned here (debian, sles, kali).

@macEar this looks like a bug in Fleet. If it still exists, this is something the Fleet team will likely address in the upcoming release.

In Fleet v4.10.0 (latest release), does the Linux hosts number still show the incorrect count? I'd like to include this information in the bug report issue.

noahtalerman commented 2 years ago

Please extend the list of supported built-in labels

@macEar adding more built in labels in Fleet is something the Fleet team can't commit to addressing now. This is something we might come back to in the future.

Why would you like to have these labels as built-in labels in Fleet? As opposed to creating a custom label.

noahtalerman commented 2 years ago

@xpkoala I added the "bug" and ":reproduce" label to this issue so that it's added to the list of unassigned bugs.

I also added the "+more info please" label because we're waiting for a response.

When macEar is able to reproduce in Fleet 4.10.0 can you please file a separate bug report issue? Then, please remove the "bug" and "reproduce" labels from this issue here.

macEar commented 2 years ago

@noahtalerman It looks like I've disinformed you. In 4.10.0 there is no issue with total host number. So this question has been addressed.

Within this case I requested adding new built-in labels for operating systems only to cover as many OS as we can out of the box. Nothing critical, just a little enhancement. For now I've added custom labels in my Fleet instance.

noahtalerman commented 2 years ago

In 4.10.0 there is no issue with total host number

Thanks for the following up! I'm glad the issue is resolved.

to cover as many OS as we can out of the box

@macEar thanks for expanding on your use case. When you have the chance to answer, I have two additional questions:

When you filed this issue were you adding Linux servers (Azure, EC2 instances) or workstations (laptops, desktops) to Fleet?

When you originally filed this issue, were you just starting to use Fleet? I'm wondering if these built-in labels would be most valuable for users that are new to Fleet and osquery.

macEar commented 2 years ago

When you filed this issue were you adding Linux servers (Azure, EC2 instances) or workstations (laptops, desktops) to Fleet?

Linux servers

When you originally filed this issue, were you just starting to use Fleet? I'm wondering if these built-in labels would be most valuable for users that are new to Fleet and osquery.

No, for that moment we'd been using Fleet for several years (previously known as Kolide Fleet).