Puppet module always reports all profiles as changed

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)

https://fleetdm.com

Other

3.01k stars 418 forks source link

Puppet module always reports all profiles as changed #12480

Closed roperzh closed 1 year ago

roperzh commented 1 year ago

🧑‍💻 Expected behavior

If a profile didn't change during a Puppet run, the profile should be reported as unchanged.

💥 Actual behavior

All profiles are always reported as changed.

👣 Reproduction steps

Assign a profile to a host in puppet
Trigger a run
Trigger a second run
Notice how the reporter says that the resource has changed even though it really hasn't

Why is this important

People rely on Puppet reports to understand what changed on a node during a Puppet run. Having a clear and accurate picture is important because there are other observability metrics that feed on this data.

roperzh commented 1 year ago

👋 hey @rachaelshaw , to implement this I'm going to need a new API endpoint that returns the hashes of all the configuration profiles in a device.

The API path will be something like:

GET /api/_version_/fleet/mdm/hosts/uuid/profiles

The response will look something like:

[
  {"identifier": "com.apple.test", "md5_checksum": "1111"},
  {"identifier": "com.macadmins.nudge", "md5_checksum": "2222"},
]

any thoughts/feedback?

fleet-release commented 1 year ago

Puppet's mirror, true, Reflects changes, clear as dew, Trust in data grew.