fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.08k stars 425 forks source link

UI: Script library for Windows #14752

Closed georgekarrv closed 11 months ago

georgekarrv commented 1 year ago

Figma

georgekarrv commented 12 months ago

Hey team! Please add your planning poker estimate with Zenhub @ghernandez345 @gillespi314

jacobshandling commented 11 months ago

@noahtalerman @marko-lisica I've updated the description of this ticket with what seem to me to be the directly relevant information from the parent epic. That epic says the Figma specifies what the activity feed items should look like, but there's nothing about activity items there. Please advise.

marko-lisica commented 11 months ago

@jacobshandling I think this should have already been implemented as a part of #9537. That's why I skipped this here since there shouldn't be any change to the activity feed. Activity feed item should display name of Windows script instead of macOS script (e.g. Anna Chao added script change-background.ps1 to Workstations team) #9537 Figma

Looking now at Audit logs, seems there's no script name for activity when IT admin runs saved script. @noahtalerman Did we cut this in the first iteration? I see here you added note for end user only.

jacobshandling commented 11 months ago

@marko-lisica thanks. The Figma didn't say anything about Observers+ permissions for run action, and uses different wording regarding observers though it seems like it means the same – can you please confirm if the below understanding is correct:

Run action available to {globalteam} maintainer, {global|team} admin, {global|team} observers+, {global|team} observers

aka – everyone can run a script...?

marko-lisica commented 11 months ago

Run action available to {globalteam} maintainer, {global|team} admin, {global|team} observers+, {global|team} >observers aka – everyone can run a script...?

@jacobshandling That's right. All roles should be able to run saved scripts on a host details page.

jacobshandling commented 11 months ago

Thanks @marko-lisica. One more for ya – I think we can improve the copy here, maybe either: "Couldn't upload. Scripts should be of type .sh or .ps1." or maybe take the error message from the response, which should say exactly why the upload failed. Wdyt?

cc @jahzielv – probably should put this in the error response instead of hardcoded on the front

jacobshandling commented 11 months ago

also do you think it would look better to have either periods or no periods on both of these lines?

Private Zenhub Image

marko-lisica commented 11 months ago

I think we can improve the copy here, maybe either: "Couldn't upload. Scripts should be of type .sh or .ps1." or maybe take the error message from the response, which should say exactly why the upload failed. Wdyt?

@jacobshandling I would keep copy from Figma, for 2 reasons. It's consistent with a custom profiles UI and error messages we show there. Also, .sh is not really a script type, as far as I know, we can have different script types in a .sh file.

marko-lisica commented 11 months ago

also do you think it would look better to have either periods or no periods on both of these lines?

@jacobshandling I'm not sure about this one. I consider first line as a title, which usually doesn't end with period. @rachaelshaw @noahtalerman What do you think about this one?

noahtalerman commented 11 months ago

What do you think about this one?

@marko-lisica up to you on periods or no periods. Is it a complete sentence? What do we do in other parts of the UI?

marko-lisica commented 11 months ago

@noahtalerman Usually we don't use periods in the headings. A similar example would be an empty state on Hosts page.

Screenshot 2023-11-21 at 12 56 09

I would keep it as it is in the Figma.

noahtalerman commented 11 months ago

Heads up @jacobshandling ^^

fleet-release commented 11 months ago

Windows scripts shine, Sorting brings clarity, peace, Fleet's strength underlines.