UI: Script library for Windows

[georgekarrv]

Figma

• [x] Controls > Scripts
  • [x] Enable .ps1 files for upload, can already upload .sh
  • [x] Add "ps1" graphic
  • [x] File uploader
  • [x] Script list on render
  • [x] Update copy x 3
  • [x] Update error message copy (backend task. waiting for product input, see comments)
  • [x] Order uploaded scripts alphabetically by name
  • [x] Display platform under script names, determined from file extension
  • [x] Include "•" between list item details
• [x] Host Details > Scripts
  • [x] Tab appears only for Mac and Windows hosts
  • [x] "GET /hosts/{id}/scripts returns only .ps1 scripts for Windows hosts, and .sh scripts for macOS hosts." - ensure only .ps1 are shown for windows hosts, .sh for mac hosts (test once API is finished)
  • [x] Run action available to {globalteam} maintainer, {global|team} admin, {global|team| observers+, {global|team} observers
  • [x] Get clarification on correct permissions here
• [x] Activity Feed - double-check that no changes needed here (i.e., confirm that Windows script names are displayed correctly in existing activity feed items)

[georgekarrv]

Hey team! Please add your planning poker estimate with Zenhub @ghernandez345 @gillespi314

[jacobshandling]

@noahtalerman @marko-lisica I've updated the description of this ticket with what seem to me to be the directly relevant information from the parent epic. That epic says the Figma specifies what the activity feed items should look like, but there's nothing about activity items there. Please advise.

[marko-lisica]

@jacobshandling I think this should have already been implemented as a part of #9537. That's why I skipped this here since there shouldn't be any change to the activity feed. Activity feed item should display name of Windows script instead of macOS script (e.g. Anna Chao added script change-background.ps1 to Workstations team) #9537 Figma

Looking now at Audit logs, seems there's no script name for activity when IT admin runs saved script. @noahtalerman Did we cut this in the first iteration? I see here you added note for end user only.

[jacobshandling]

@marko-lisica thanks. The Figma didn't say anything about Observers+ permissions for run action, and uses different wording regarding observers though it seems like it means the same – can you please confirm if the below understanding is correct:

Run action available to {globalteam} maintainer, {global|team} admin, {global|team} observers+, {global|team} observers

aka – everyone can run a script...?

[marko-lisica]

Run action available to {globalteam} maintainer, {global|team} admin, {global|team} observers+, {global|team} >observers aka – everyone can run a script...?

@jacobshandling That's right. All roles should be able to run saved scripts on a host details page.

[jacobshandling]

Thanks @marko-lisica. One more for ya – I think we can improve the copy here, maybe either: "Couldn't upload. Scripts should be of type .sh or .ps1." or maybe take the error message from the response, which should say exactly why the upload failed. Wdyt?

cc @jahzielv – probably should put this in the error response instead of hardcoded on the front

[jacobshandling]

also do you think it would look better to have either periods or no periods on both of these lines?

Private Zenhub Image

[marko-lisica]

I think we can improve the copy here, maybe either: "Couldn't upload. Scripts should be of type .sh or .ps1." or maybe take the error message from the response, which should say exactly why the upload failed. Wdyt?

@jacobshandling I would keep copy from Figma, for 2 reasons. It's consistent with a custom profiles UI and error messages we show there. Also, .sh is not really a script type, as far as I know, we can have different script types in a .sh file.

[marko-lisica]

also do you think it would look better to have either periods or no periods on both of these lines?

@jacobshandling I'm not sure about this one. I consider first line as a title, which usually doesn't end with period. @rachaelshaw @noahtalerman What do you think about this one?

[noahtalerman]

What do you think about this one?

@marko-lisica up to you on periods or no periods. Is it a complete sentence? What do we do in other parts of the UI?

[marko-lisica]

@noahtalerman Usually we don't use periods in the headings. A similar example would be an empty state on Hosts page.

I would keep it as it is in the Figma.

[noahtalerman]

Heads up @jacobshandling ^^

[fleet-release]

Windows scripts shine, Sorting brings clarity, peace, Fleet's strength underlines.