Show Munki issues section only if Munki version present in the `/hosts/:id/macadmin`

[marko-lisica]

Fleet version: Fleet 4.41.0

Web browser and operating system: Google Chrome 120.0.6099.71

---

💥  Actual behavior

🧑‍💻  Steps to reproduce

1. Open the Host details page
2. Go to the Software tab
3. Scroll on the bottom of the page

To fix

Only show the Munki issues card if the host has Munki.

This is determined by the presence of a Munki version in the hosts/:id/macadmins API endpoint.

[sabrinabuckets]

@marko-lisica should this really be a bug? I would expect that if Munki is configured, I would see this "zero state" for issue reporting. Whereas, I would only expect to not see the card at all if Munki isn't configured for the Fleet instance (as is the case with my local). In the case of the latter, I still have this card present.

[marko-lisica]

@marko-lisica should this really be a bug? I would expect that if Munki is configured, I would see this "zero state" for issue reporting. Whereas, I would only expect to not see the card at all if Munki isn't configured for the Fleet instance (as is the case with my local). In the case of the latter, I still have this card present.

Good point @sabrinabuckets. I'm not very familiar how Munki feature works, but it makes sense to hide the card if it is not configured and show empty state if there are no issues. @noahtalerman What do you think?

[noahtalerman]

Hey @sabrinabuckets and @marko-lisica it's a bug.

Here's the original spec in Figma: https://www.figma.com/file/PrWu3D5vobpO2yi6dtoRI5/Fleet-(2022-archive)?type=design&node-id=313%3A23084&mode=design&t=eQg5nmLJY7pTh1pa-1

I added the "To fix" section to the issue description to describe this.

[sabrinabuckets]

@noahtalerman just to clarify (and I think maybe an issue title update is needed) the bug is if the card is displayed when Munki is not configured, yes?

The original description was calling attention to a case where Munki is configured but there are no issues, which appears to me to be an expected behavior.

[marko-lisica]

the bug is if the card is displayed when Munki is not configured, yes?

@sabrinabuckets Based on original designs I think so. I guess Munki can't be installed on the host if it's not configured. So Munki issues section wouldn't be displayed if GET /hosts/:id/macadmins returns munki: null as @noahtalerman described in the issue description.

[sabrinabuckets]

Makes sense to me!

[jacobshandling]

@marko-lisica can you please help me reproduce this by specifying the repro instructions a bit? I'm only seeing either the presence of the munki field with contents or it missing altogether, in which case the card isn't rendered. I'm not seeing the field present and null, as in{macadmins: {munki: null}}

[jacobshandling]

looks like this only occurs for hosts enrolled in MDM

[jacobshandling]

Successfully reproduced and manually QAed solution, so all set

[fleet-release]

Munki issues concealed, When none exist, clarity revealed. Fleet-user's path is healed.