search

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.02k stars 419 forks source link

Double "View all hosts" on Controls > OS settings > Disk encryption page #15731

Closed noahtalerman closed 9 months ago

noahtalerman commented 9 months ago

Fleet version: Observed in Fleet's dogfood environment (f351568)

💥  Actual behavior

Screenshot 2023-12-18 at 5 11 03 PM

Expected behavior is to see one View all hosts button at the end of the row. See Figma here.

sabrinabuckets commented 9 months ago

@noahtalerman I feel like this one needs some Product/Design input. Those filters are technically correct in that they show you either all macOS or all Windows hosts for that status. It seems to me that we'd want that. And if there really does need to be only one, then we'd probably need a Total hosts column of some sort, otherwise the current UI doesn't make sense.

sabrinabuckets commented 9 months ago

Brought this up during Product Office Hours. We confirmed that currently both links direct to a platform agnostic filter, and so for the current iteration it does make sense to remove the secondary link & align with the Figma (linked in description). @noahtalerman mentioned that a follow-up later could involve refining it to have platform-specific filters.

lukeheath commented 9 months ago

@noahtalerman @marko-lisica Question on this:

Should I still see both columns if I have only Apple MDM or Windows MDM enabled? Or do we want to only show both columns if both are enabled?

noahtalerman commented 9 months ago

Should I still see both columns if I have only Apple MDM or Windows MDM enabled? Or do we want to only show both columns if both are enabled?

@lukeheath you should see both the "macOS" and "Windows" columns in these (all?) scenarios:

Looks like this one was in a dev note from the Figma:

Screenshot 2024-01-08 at 12 19 48 PM

So, using the bug categories we're going to try, I think we would categorize as bug-figma?

cc @marko-lisica

lukeheath commented 9 months ago

@noahtalerman Thanks for pointing that out. Yes, this is a bug-figma.

lukeheath commented 9 months ago

@noahtalerman I'm actually going with bug-ui-wireframes when the wireframes were not correctly implemented. That way, if we ever change design software, we won't have to rename the label.

sabrinabuckets commented 9 months ago

Verified there is now a unified "View all hosts" filter for both OS types, filter is applied correctly

fleet-release commented 9 months ago

One button to see, All hosts in clarity, Efficiency, set free.