Open marko-lisica opened 10 months ago
Heads up @marko-lisica this request was discussed during feature fest last week and didn't make it into the current design sprint.
Hey @pintomi1989 heads up, this story was prioritized during feature fest.
Aiming to ship an improvement in the next 6 weeks.
Hey team! Please add your planning poker estimate with Zenhub @dantecatalfamo @ghernandez345 @gillespi314 @jahzielv @mna @roperzh
Goal
Changes
Requirements
device_mapping
) without having to type full email (e.g. If the user searches formark
Fleet should list hosts that have emailmarko@example.com
)Product
Engineering
Requires changing how we detect if a search could be an email address, which was done for performance reasons to avoid joining with
host_emails
unless necessary.We should plan load testing the new search to see if the impact is acceptable at scale for non-email searches.
We have a special-case in place to do an additional search when non-ASCII is used (to account for unicode chars equivalence, IIRC it was mostly for things like apostrophes), but now we would do it even if it includes the email search (since we wouldn't detect the search as being "email-like")
This also affects
ListHosts
,CountHosts
,ListHostsInLabel
andCountHostsInLabel
(which I think is required so that the exact same criteria can be used for those). To keep in mind when load testing performance.[ ] Database schema migrations: TODO
Context
QA
Risk assessment
Manual testing steps
Testing notes
Confirmation