Upcoming activities: Add MDM commands

[noahtalerman]

Goal

User story
As an endpoint operator on the Host details page,
I want to see a list of the upcoming MDM commands and scripts
so that I know what upcoming commands/scripts will run on a specific host.

Objective

Mission critical MDM replacement

Original requests

• 20712

Changes

Product

• [ ] UI changes: Figma link
• [ ] REST API changes: Figma link
• [ ] Permissions changes:
  • Admins, maintainers, and observers can see all activity for hosts that they have access to.
  • A user w/ access to specific teams (not global) can only see activity for hosts assigned to this users team(s). If they hit GET /hosts/:id/activities or GET /hosts/:id/activities/upcoming for a host that they don't have access to, they'll get a forbidden response (403) with this error message: Error: You don’t have permission to view activities. The host belongs to a team you don’t have permissions to view.
• [ ] Outdated documentation changes:
  • Add a GET /hosts/:id/activities and GET /hosts/:id/activities/upcoming section in the API for contributors docs. These sections will list all possible activities across all platforms and link to example usage in the REST API docs.
  • In the GET /hosts/:id/activities and GET /hosts/:id/activities/upcoming REST API docs link to the full list of all possible activities in contributor docs.
  • In the release article (or maybe it's own article) describe the first-in-first-out for scripts and MDM commands.
• [ ] Changes to paid features or tiers: Available in Fleet Free and Fleet Premium

Engineering

• [ ] Database schema migrations: TODO
• [ ] Load testing: TODO

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

Context

• Requestor(s): _____

QA

Risk assessment

• Risk level: Low

Manual testing steps

1. Validate MDM & DDM activity shows up in feed.
2. Validate Script activity shows up in feed.
3. Validate API activity
4. Validate loading & error state in UI
5. Test upcoming & past feeds
6. Verify details modal match Figma
7. Test created, deleted, ran, installed...
8. Test macOS, Windows, and Linux

Testing notes

NOTE: New users will be displayed in the activity feed, mdm commands that were run prior to update will show "a user" Additional note: some of these tasks are already complete. e.g. Script and software installs

Confirmation

1. [ ] Engineer (@____): Added comment to user story confirming successful completion of QA.
2. [ ] QA (@____): Added comment to user story confirming successful completion of QA.

[noahtalerman]

@georgekarrv heads up, we moved this story to "Settled." I think we can start the spec'ing process while Rachael takes a look at API design.

@rachaelshaw when you get the chance, can you please take a look at the API design in Figma?

Please let us know if y'all have any feedback or questions.

[marko-lisica]

@roperzh Based on our discussion during design review today. This is behaviour we want:

• For profiles added after this release, we want any new activities to display the latest name of the user (whether the user is deleted or not).
• For profiles added before the release, we’re ok w/ new activities displaying “a user” (because we don’t have a user associated w/ that action)
• Generally, we want activities to reflect the data that is available to Fleet at the time when the activity is generated. We don’t want to update old activities

cc @noahtalerman

[georgekarrv]

@noahtalerman For review

[marko-lisica]

Hey @georgekarrv I assigned myself to the story. I'll double-check if the designs are stale before we proceed.

[noahtalerman]

Hey @georgekarrv, heads up, I pulled the sub-tasks off drafting board (removed :product) to clean up the board. I think we can pull them back on when this story is ready for re-estimation.

cc @marko-lisica

[georgekarrv]

Listing out how this can be split

• MacOS profiles
• Windows profiles
• MDM command macOS
• MDM command Windows
• Disk encryption macOS
• Disk encryption Windows
• Windows Updates
• Locked macOS
• Locked / Unlocked Windows / Linux
• Wiped macOS
• Wiped Windows
• Wiped Linux
• macOS Declarations

team said 3sp for UI for each and 5sp for backend each so napkin math 13*8 -> 104sp but we can slice and dice it to pick and choose which of these to prioritize.

[noahtalerman]

Hey @georgekarrv, @marko-lisica, and @Patagonia121 heads up, I pulled this story and #20301 (and sub-tasks) off the drafting board because it wasn't prioritized in the engineering sprint we just kicked off.

When we revisit this one, let's dig into the building one queue now v. unifying the queue later.

[lukeheath]

@georgekarrv I noticed the estimation on this and it seems very high. Each UI activity item is estimated at 3 points, but adding one activity item to the UI does not take an entire day (it takes me about one hour). In the VPP story, adding 5 UI activity items was estimated at a 3. Let's dig into these estimations before we bring into the next sprint; I may be missing something. Thanks!

[noahtalerman]

Hey @marko-lisica, heads up that I moved this story and "Fleet-initiated" story (#20712) into the drafting board.

When you get to this story, can you please bring Fleet-initiated designs into this story and close out the Fleet-initiated story (#20712) to simplify things for us? One story for adding MDM commands to the activity feed.

I think let's not worry about breaking up the story until we get to estimation.

[noahtalerman]

Hey @zayhanlon and @Patagonia121 heads up, this user story and the following stories didn't make it into the upcoming engineering sprint because we didn't wrap up designs in time.

• 20301

• 21681

They're still prioritized. We left it on the drafting board so that it can be pulled into the next engineering sprint.

[noahtalerman]

Hey @marko-lisica @Patagonia121 and @zayhanlon, I pulled this user story and the following user stories off of the drafting board (de-prioritized)

• 20301

• 21681

We're prioritizing the "Upcoming activities run as listed (one queue) and can be canceled" story (#22866) first. This story, targeted for the next eng sprint (4.60), will simplify the piping (backend) so that we can build future activity feed features faster.

Then, the plan is to prioritize parts (or all) of #15920, #20301, #21681 in following engineering sprints.