Closed rachaelshaw closed 4 months ago
@rachaelshaw we moved the original issue description here:
The MDM section of the REST API has a lot of endpoints compared to other sections (26), and is getting a bit unwieldy to navigate.
It would be easier for people to find what they're looking for if we moved away from nesting the APIs for MDM features under /mdm/, and recategorized & set up redirects for existing MDM endpoints.
@noahtalerman here's the spreadsheet I started to figure out the new URLs + categories if you want to leave feedback: https://docs.google.com/spreadsheets/d/1aH1fTtrpftmwglxVuYqXUSfIRfhk88x5ORVUcIQhdbs/edit#gid=907717004
Hey team! Please add your planning poker estimate with Zenhub @ghernandez345 @gillespi314 @mna @roperzh
As discussed in estimation, linking to this ticket that also relates to the disk encryption endpoint
Note that the scope of this ticket (as estimated) does not cover updating the UI/fleetctl
/fleetd
to use the new endpoints.
@noahtalerman @rachaelshaw I updated the spreadsheet while implementing the new endpoints, I highlighted in yellow the endpoints that are not platform-agnostic yet (either because they specifically require Apple MDM to be enabled or because they only apply to Apple, at least for now), and in green those that work for either Windows or Apple MDM.
This is just a heads-up, I don't think it's an issue for now, it's to make it clear that as part of this story, we're just making the new routes available, there's no change to the implementation (except for "Update disk encryption enforcement" which couldn't be a simple route path change). And as mentioned in my comment above, the UI/CLI/agent are not updated to use the new routes either. (I can create a new ticket as a follow up for this, let me know if there's not already something to track this work)
Also, did we reach a decision regarding /abm
and /apns
vs the non-acronym form? Referring to this: https://github.com/fleetdm/fleet/pull/16728/files#r1488694302 and https://github.com/fleetdm/fleet/pull/16728/files#r1488694787.
QA: went through all the endpoints listed here: https://github.com/fleetdm/fleet/pull/16728 , both the old version and the new version using curl
and everything worked fine.
C&C: need to make fresh PRs to the docs (draft PR was open a long time, messing with the PR open time KPI). TODO @rachaelshaw
C&C: Doc PRs are still open. cc @rachaelshaw
Docs PR is merged! https://github.com/fleetdm/fleet/pull/18886
Endpoints shift, aligned, Fleet core, MDM enshrined. Clear path, users find.
Goal
/mdm
Changes
Product
Engineering
Context
QA
Risk assessment
Manual testing steps
Testing notes
Confirmation