Scope scheduled queries with labels

pintomi1989 commented 9 months ago

Goal

User story
As a user adding/editing a query,
I want my scheduled query to target hosts based on labels
so that I can target a more specific set of hosts.

Context

Requestor(s): @pintomi1989
Product designer: @rachaelshaw

Changes

Product

[ ] UI changes: Figma
[ ] CLI usage changes: Figma
[ ] REST API changes: Draft PR
- API Error messages are in Figma
[ ] Outdated documentation changes: REST API docs (see draft PR)
[ ] Changes to paid features or tiers: Fleet Premium feature.

Engineering

[ ] Database schema migrations: TODO
[ ] Load testing: TODO

ℹ️ Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

Requires load testing: TODO
Risk level: Low / High TODO
Risk description: TODO

Manual testing steps

Step 1
Step 2
Step 3

Testing notes

Confirmation

[ ] Engineer (@____): Added comment to user story confirming successful completion of QA.
[ ] QA (@____): Added comment to user story confirming successful completion of QA.

noahtalerman commented 8 months ago

@rachaelshaw we decided we want to purge the query report if a query's platforms, labels, or minimum osquery version change, right? (each option changes the targets)

I updated this dev note to reflect this:

Screenshot 2024-03-01 at 10 00 10 AM

noahtalerman commented 8 months ago

@rachaelshaw heads up, I added this sentence to the dev note here to clarify the behavior when there are no matching hosts:

Screenshot 2024-03-01 at 10 02 46 AM

(Mike brought this up during "Product design check-in call"

rachaelshaw commented 8 months ago

@rachaelshaw we decided we want to purge the query report if a query's platforms, labels, or minimum osquery version change, right? (each option changes the targets)

@noahtalerman yes; handling platforms/min version change is filed as a bug here: https://github.com/fleetdm/fleet/issues/17018

sharon-fdm commented 8 months ago

Estimation: BE:5 FE:3

noahtalerman commented 5 months ago

Hey @rachaelshaw curious on why this is coming back to feature fest. Did a customer bring this up recently? Or, is it because we have some pretty much ready-to-go designs?

rachaelshaw commented 5 months ago

@noahtalerman just brought it back because we already had it designed/estimated (not aware of any customer requests other than those tagged on the issue)

fleetdm / fleet