search

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3k stars 416 forks source link

Improve error state component #17204

Open marko-lisica opened 7 months ago

marko-lisica commented 7 months ago

Goal

User story
As an IT admin,
I want to see the consistent error states in the UI
so that I easily understand what's wrong and how to file an issue.

Context

Changes

Product

Engineering

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

Manual testing steps

  1. Step 1
  2. Step 2
  3. Step 3

Testing notes

Confirmation

  1. [ ] Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. [ ] QA (@____): Added comment to user story confirming successful completion of QA.
georgekarrv commented 7 months ago

Hey team! Please add your planning poker estimate with Zenhub @ghernandez345 @gillespi314

jacobshandling commented 2 months ago

Since the original Figma for this ticket contained this new Data Error component, I ended up building it within the existing DataError, and adding a useNew prop to that component to flag whether to use the new version or not. Whoever picks up this ticket can start from there. I was not aware of the highly detailed Figma (thanks @marko-lisica!) here, so that engineer will want to double-check the specifics.