search

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
2.73k stars 390 forks source link

Update Fleet Desktop to support a different display number on Ubuntu hosts #17660

Open noahtalerman opened 4 months ago

noahtalerman commented 4 months ago

Goal

User story
As an endpoint operator who has Ubuntu (Linux) hosts w/ DISPLAY set to :1,
I want to see the Fleet Desktop icon
so that I can get to the My device page.

Context

Changes

Product

Engineering

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

Manual testing steps

  1. Step 1
  2. Step 2
  3. Step 3

Testing notes

Confirmation

  1. [ ] Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. [ ] QA (@____): Added comment to user story confirming successful completion of QA.
noahtalerman commented 3 months ago

We discussed this request at feature fest.

We decided not to draft this one in the upcoming design sprint (4.49).

Removing from feature fest board.

pintomi1989 commented 3 months ago

Customer-honoria update: Linux usage is small, easy to overcome

noahtalerman commented 2 months ago

Lucas from #18925: After disabling Wayland (and using X11 instead, which is what Ubuntu < 24.04 are using), it seems the DISPLAY environment variable is :1 (fleetd assumes :0). Which is the reason clicking on My device/Transparency doesn't work.

So, we could provide (with minimal code changes) a workaround for Ubuntu 24.04 by allowing users to set a specific display variable (as defined in https://github.com/fleetdm/fleet/issues/17660) e.g. fleetctl package --override-display=:1 and ORBIT_OVERRIDE_DISPLAY=:1.

fleet-release commented 2 months ago

Ubuntu hosts shine, Fleet Desktop icon gleams, Path to device, streamlined.

lucasmrod commented 2 months ago

(Reopening, was closed automatically by Github.)