fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.06k stars 424 forks source link

Windows not displaying characters p/g correctly #18539

Open getvictor opened 6 months ago

getvictor commented 6 months ago

Fleet version: <!-- Copy this from the "My account" page in the Fleet UI, or run fleetctl --version --> Fleet fleet-v4.49.0-25-gddaa8c9e2-dirty

Web browser and operating system: Microsoft Edge 124.0.2478.51 running on

image.png

💥  Actual behavior

https://www.loom.com/share/f4fce81abbf047bc894558fb672081f7

🧑‍💻  Steps to reproduce

  1. Use Fleet UI on Windows Edge
  2. Go to Host Details page

🕯️ More info (optional)

N/A

sharon-fdm commented 5 months ago

Lucas: This could be a specific VM issue.

getvictor commented 5 months ago

I confirmed that I also see it on Chrome in Windows, and the issue goes away at higher/lower zoom levels: https://www.loom.com/share/b140b0f777254591bb4f6bea9261944b

sharon-fdm commented 5 months ago

Timebox to 2 pts. Raise a flag if needs more time.

RachelElysia commented 4 months ago

Not replicating on my Microsoft Edge, latest version.

Screenshot 2024-06-03 at 12.53.02 PM.png

Will download version 124.0.2478.51 and see if it was a version issue.

RachelElysia commented 4 months ago

Ok, now reproducing on Chrome as well on my Windows VM. >.< Looking into fix now.

RachelElysia commented 4 months ago

@getvictor

Are you also only seeing this bug on a VM running on Mac? So I was able to narrow this down and fix it as a VM display issue.

Before the fix, I was seeing the issue on both Chrome and FF, but only for "p" and "g" characters that were bolded. When I switched magnification, I saw it only on "n" characters.

Example of bug I was seeing:

Screenshot 2024-06-03 at 1 31 57 PM

I was able to fix it on my Win 10 VM by going to VMWare Fusion > Virtual Machine > Install VMWare tools and selecting Complete installation instead of Typical. This solution also made my entire Windows VM a lot clearer, not just on the Fleet desktop browser view.

Examples of fix for 2 browsers, Edge and Chrome:

Screenshot 2024-06-03 at 4 38 25 PM Screenshot 2024-06-03 at 4 38 01 PM

If I changed any of the display settings on my VM, the issue would reappear.

tldr: So it seems like the issue for me is running Windows as a VM in VM Ware on mac with a retina display. The solution is only to install VMWare Tools > Complete package and not modify the display settings for my VM.

Let me know if that fixes your Win 11 issues as well. I think we can document this somewhere and close it out as a non-bug. Let me know if you agree.

RachelElysia commented 4 months ago

Perplexity.ai's answer: https://www.perplexity.ai/search/What-can-be-3snjhdWnRGK77r2Pi_wDNQ

RachelElysia commented 4 months ago

@getvictor bump

In passing you mentioned you have a different VM setup. Just wanted to confirm you're only seeing this on a VM and see if there's settings that will fix this issue for you as well or if there's a VM agnostic solution.

getvictor commented 4 months ago

Yes, I'm seeing it in a VM running on QEMU+KVM with the following display settings:

image

Changing resolution to 1920x1080 doesn't fix the issue.

getvictor commented 4 months ago

It is curious that I can't reproduce it on fonts.google.com, which suggests there is something in our styling that's causing this.

image
ari-wein commented 3 months ago

Just adding here that I see the same issue, running windows on bare metal with chrome on fleet 4.53.1. My resolution is 2560x1440, and the problem only really goes away when I zoom in to 250%. It also happens on the 1920x1080 laptop screen.

ari-wein commented 3 months ago

It looks like the font family changed? Im not a CSS expert at all, but some poking shows that the font family on an older instance of fleet had the font family Nunito Sans while the latest version has Inter. manually changing it back to Nunito Sans fixed the issue for me. looks to have changed in this commit: https://github.com/fleetdm/fleet/commit/49eb3885f80b906f825b9b66d312549c7219ade8 image image