Closed jacobshandling closed 1 week ago
Great idea! This change seems to require a visible product change, so routing it to Noah and feature fest.
Hey @jacobshandling thanks for filing this!
clean up and make consistent this UI/code
We treat inconsistent styles as bugs so I'm transforming this feature request to a bug. Moving it to the product board because it sounds like we need some wireframes. cc @lukeheath @rachaelshaw
Do you have some examples/screenshots of the inconsistency? Like two different pages w/ different styles?
Do you have some examples/screenshots of the inconsistency? Like two different pages w/ different styles?
@noahtalerman this has come up in a couple of places, with Figmas sometimes asking for one, sometimes the other. This is 2 months old, and it may now be the case that we display "0 things" everywhere. I don't have any examples/screenshots of the "No things" situation, as it may not exist at this point.
Which is why I didn't file it as a bug
@jacobshandling got it! Thanks.
I don't have any examples/screenshots of the "No things" situation, as it may not exist at this point.
Ok. Makes sense to keep it as a bug so we can spend a bit of time coming up w/ the expected UI (sounds like it's "0 things") and then answering the question of whether there's any spots where we don't follow the expected UI.
@jacobshandling after thinking about this, how common is it that we show a "0 things" in the UI?
I think we have empty states for most tables and I think in this case we hide the count so the user never sees "0 things".
What are the places where we don't have an empty state and we show "0 things"?
I think we want to consider adding an empty state in these cases.
I added a proposed research task to this bug and moved this bug to the release board.
cc @sharon-fdm
Hey team! Please add your planning poker estimate with Zenhub @jacobshandling @RachelElysia
Closing per @noahtalerman's request.
Zero things appear, Consistency brings calm peace, In the cloud city's glass sphere.
@noahtalerman @jacobshandling
I think this is still a bug: some tables don't show the 0 count. Some do:
Here's examples I found that show "0 things"
Hey @RachelElysia, thanks for digging!
some tables don't show the 0 count.
Which don't? I think let's break out a bug for that. Or re-open this one.
Here are tables that do not show 0 count.
We definitely should be consistent.
@noahtalerman @jacobshandling @sharon-fdm re-opened since this is an inconsistent UI bug.
Thanks @RachelElysia! Good find.
I updated this bug to focus on the places that we found are missing counts: Software tables.
This may be addressed by my current work for #20467
Per Slack, the above work didn't address this, so we're starting from no WIP here (though we of course have other examples of this being handled correctly).
Will dig into this as my next thing.
Are we okay with this? (specifically the "updated never")
Beyond that, here's vulns:
and here's software:
Missing counts appear, Like dewdrops on spring morning, Clarity restored.
Fleet version: Observed in Fleet's dogfood environment
💥 Actual behavior
When searching on the Software > Software, Software > OS, and Software > Vulnerabilities tables, I don't see a count when there are no search results:
🛠️ To fix
In the no search results state, display the count (0) so that we're consistent w/ other tables in the UI.