Add renewal banner for Volume Purchasing Program

marko-lisica commented 3 months ago

Goal

User story
As a Fleet user,
I want to know when my VPP token is about to expire (starting 30 days before)
so that I can renew this token before the VPP service stops working.

Context

Product designer: @marko-lisica

Design reminder banner but have other banners and order of display in mind. See #11544 for more context.

Changes

Product

[x] UI changes: Figma link
[x] REST API changes: Use API endpoint that will be done as part of #18867
[x] Other changes: ~~Redirects for renewing VPP token docs.~~ New VPP section on ~~Setup page.~~
- UPDATE: macOS MDM setup is now a guide here: https://fleetdm.com/guides/macos-mdm-setup (@noahtalerman)
- UPDATE: No need for a redirect anymore. See comment here: https://github.com/fleetdm/fleet/issues/19691#issuecomment-2320625687

Engineering

[ ] Database schema migrations: TODO
[ ] Load testing: TODO

ℹ️ Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

Risk level: Low
Manual testing steps

Tweak DB to mimic expiring and expired VPP certs
Ensure expiring banner shows within 30 days of expire date
Ensure expired banner shows after cert expires
Check the Link resolves to Rnew VPP portal
Ensure the order of preference for other banners meets the criteria described in Figma

Testing notes

Confirmation

[ ] Engineer (@____): Added comment to user story confirming successful completion of QA.
[ ] QA (@____): Added comment to user story confirming successful completion of QA.

marko-lisica commented 2 months ago

@georgekarrv heads up. This one is ready to be estimated.

georgekarrv commented 2 months ago

We are seeing the tech debt grow for not working on the notifications endpoint

georgekarrv commented 2 months ago

Hey team! Please add your planning poker estimate with Zenhub @ghernandez345 @gillespi314

PezHub commented 1 month ago

QA Notes:

I was able to tweak DB to mimic expiring and expired VPP certs
I confirmed the Link points to https://fleetdm.com/learn-more-about/renew-vpp but the page is not up yet
Forced an MDM enrollment banner to pop up to ensure the order of preference for other banners meets the criteria described in Figma

QA Approved!

noahtalerman commented 1 month ago

[ ] Other changes: Redirects for renewing VPP token docs. New VPP section on Setup page.

Hey @ghernandez345 just checking, did you take this action item? I think we chatted about this in Slack?

noahtalerman commented 3 weeks ago

[ ] Other changes: Redirects for renewing VPP token docs. New VPP section on ~~Setup page.~~

UPDATE: macOS MDM setup is now a guide here: https://fleetdm.com/guides/macos-mdm-setup (@noahtalerman)

Hey @ghernandez345 I passed this issue in confirm and celebrate to you. It looks like there's one TODO before we close this (above)

When you get the chance, can you please add a "Volume Purchasing Program (VPP)" section the macOS MDM setup guide here?

noahtalerman commented 2 weeks ago

[ ] Other changes: Redirects for renewing VPP token docs. New VPP section on ~~Setup page.~~

UPDATE: macOS MDM setup is now a guide here: https://fleetdm.com/guides/macos-mdm-setup (@noahtalerman)

Hey @ghernandez345 I passed this issue in confirm and celebrate to you. It looks like there's one TODO before we close this (above)

When you get the chance, can you please add a "Volume Purchasing Program (VPP)" section the macOS MDM setup guide here?

Hey @ghernandez345, giving you another ping!

cc @georgekarrv

ghernandez345 commented 2 weeks ago

@noahtalerman sorry I missed you original mentions. I'm looking into this now.

ghernandez345 commented 2 weeks ago

@noahtalerman the current information lives in this guide instead https://fleetdm.com/guides/install-vpp-apps-on-macos-using-fleet under the Renewing an expired or expiring VPP token. are you happy to change the link to that?

noahtalerman commented 1 week ago

the current information lives in this guide instead https://fleetdm.com/guides/install-vpp-apps-on-macos-using-fleet under the Renewing an expired or expiring VPP token. are you happy to change the link to that?

@ghernandez345 ah! Gotcha. I missed that. I think we're good to go. No need to update the macOS setup guide.

Just to double check, do the links from the Fleet UI redirect to that VPP guide?

ghernandez345 commented 1 week ago

@noahtalerman I am updating the link in the UI now to point to this new guide. I'll let you know when it goes through

ghernandez345 commented 1 week ago

@noahtalerman When I was looking at this it seems we now link to the new VPP page in the Fleet UI (the page at /settings/integrations/mdm/vpp). We made this change as a requirement for the multiple ABM and VPP tokens feature. Here is the figma where we changed the URL to an internal page in the Fleet UI.

I'm assuming we don't need to link out to an external guide anymore, correct?

noahtalerman commented 1 week ago

@ghernandez345 that makes sense!

Closing this one out.

fleet-release commented 1 week ago

Renewal banner shines, Averts VPP token's end, Smooth sail in cloud times.

fleetdm / fleet