search

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
2.66k stars 379 forks source link

Add "Pending" and "Error" status for policies #19839

Open rachaelshaw opened 2 weeks ago

rachaelshaw commented 2 weeks ago

Goal

User story
As a user viewing policy results,
I want to see which policies have yet to run on some hosts ("Pending") and which policies ran but their query returned an "Error"
so that I can see how complete my results are and investigate hosts with an error.

Context

Changes

Product

Engineering

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

Manual testing steps

  1. Step 1
  2. Step 2
  3. Step 3

Testing notes

Confirmation

  1. [ ] Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. [ ] QA (@____): Added comment to user story confirming successful completion of QA.
noahtalerman commented 2 weeks ago

Hey @rachaelshaw are this story, #19857, and #19840 hackathon stories?

noahtalerman commented 2 weeks ago

Rachael: was discussed but I didn't file issue:

One-time query reports (no frequency, just stops after collecting results from each host) — it sounded like the policies updates would be enough to cover the customer's use cases, and this may already be doable by setting a really long frequency. I think it's an interesting concept though and might be worth bringing to Feature Fest, could definitely see people wanting to just run a one-off report.

noahtalerman commented 1 week ago

Hey @zayhanlon and @Patagonia121 heads up, the designs for this hackathon story are settled (almost ready for estimation). Here are the designs: Figma wireframes

Do we want to hop on another call w/ the customer to get their feedback?

zayhanlon commented 1 week ago

@noahtalerman Yes please! I'll coordinate

zayhanlon commented 1 week ago

@noahtalerman the person who attended hackathon precall is ooo until end of july, and the primary user of the DART team is ooo next week. primary user said they're unsure if the initial design captures what he was thinking (i shared the gong recording with him). can we hold on any action and engineering until we review? i'll schedule a call for the second week of july

@Patagonia121 fyi

JoStableford commented 1 week ago

Related to a Slack conversation

noahtalerman commented 1 week ago

can we hold on any action and engineering until we review? i'll schedule a call for the second week of july

Sounds good!

cc @rachaelshaw

sharon-fdm commented 1 week ago

Hey team! Please add your planning poker estimate with Zenhub @getvictor @jacobshandling @lucasmrod @mostlikelee @RachelElysia

noahtalerman commented 1 week ago

Hey @sharon-fdm did we estimate this one? If not, in response to @zayhanlon's comment here, I think let's wait to estimate this one until after we hop on a call w/ the customer.

Moving this one to the "Prioritized" column.

cc @rachaelshaw

sharon-fdm commented 1 week ago

Not estimated yet. NP.

rachaelshaw commented 1 week ago

So we've got a record of it for any documentation updates, here's what was previously in the FAQ about "no response" policies:

Why is my host not updating a policy's response?

The following are reasons why a host may not be updating a policy's response:

  • The policy's query includes tables that are not compatible with this host's platform. For example, if your policy's query contains the apps table, which is only compatible with hosts running macOS, this policy will not update its response if this host is running Windows or Linux.
  • The policy's query includes invalid SQL syntax. If your policy's query includes invalid syntax, this policy will not update its response. You can check the syntax of your query by heading to the Queries page, selecting your query, and then selecting "Save."