fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
2.75k stars 392 forks source link

Text wrapping in Policies > Manage Automations > Calendar events modal #20211

Closed noahtalerman closed 1 week ago

noahtalerman commented 3 weeks ago

Fleet version: Observed in Fleet's dogfood environment (4.53.1)


💥  Actual behavior

Screenshot 2024-07-03 at 3 41 19 PM

🧑‍💻  Steps to reproduce

Head to the Workstations canary team in dogfood and then head to Policies > Manage Automations > Calendar events.

🛠️ To fix

noahtalerman commented 3 weeks ago

Hey @rachaelshaw, I'm not sure what the expected behavior is here so I passed this bug to you and added it to drafting.

rachaelshaw commented 3 weeks ago

@noahtalerman what if we do overflow: ellipsis and add the full name of the policy as a title attribute so the whole thing is visible on hover?

Screenshot 2024-07-04 at 11 47 24 AM
noahtalerman commented 3 weeks ago

@rachaelshaw I like that solution! That said, is this UI pattern consistent? Do we do it elsewhere?

I think we're using Fleet's tooltips to expose info on hover. For example on the Hosts page:

Screenshot 2024-07-08 at 1 27 34 PM

rachaelshaw commented 3 weeks ago

@noahtalerman good point; my thinking behind using title here instead of a tooltip is: we expect that the policy names will usually be visible on one line. (We only have one with wrapping text out of 23 policies.) I think the tooltip feels out-of-place if it just repeats the same information you can already see. (With UUID on the host page, it's expected that you'll have enough visible columns that the full UUID won't be visible onscreen most of the time.)

noahtalerman commented 2 weeks ago

I think the tooltip feels out-of-place if it just repeats the same information you can already see.

@rachaelshaw agreed but can't we make it so the tooltip only appears if the policy is longer than one line? Policies that are one line (most) won't get a tooltip.

fleet-release commented 1 week ago

Text wraps like a stream, Ellipsis the stepping stone, Clarity, the dream.