VPP: code cleanup tasks

jahzielv commented 2 months ago

Some cleanup tasks we have to do to polish the code

[x] Move all calls to Apple APIs from service into a single dedicated package
[x] Check the VPP token expiration date
[x] Remove the added field (per here) (DONE)
[x] Add retry logic when fetching data from the Apple iTunes endpoint (DONE)
[x] ~We should probably use the country code from https://developer.apple.com/documentation/devicemanagement/client_config to use the correct storefront when fetching assets~ This is a non-issue, because the endpoints we're using right now doesn't use country codes. It may be an issue in the future if we decide to move off of the public iTunes endpoint.
[x] Check with Marko if we're supposed to be setting a non-0 value for ManagementFlags (see comment) (This is OK for now. We will do research in the future to see if the flags should be something different.)
[x] Update source field to be apps (UI should render as Application (MacOS)) (PR)
[x] Replace temporary DB accesses in test with actual datastore methods (PR)
[x] Check if it's worth storing the VPP token raw, or if we should go back to storing it base64 encoded (PR).
[x] Add integration tests for VPP apps in List software titles / get software title (ticket https://github.com/fleetdm/fleet/issues/19880) and use the Datastore methods in the DB tests. I didn't add them then to avoid using raw SQL just to replace them later by the actual API endpoints. (PR)

[x] Check with Marko what sort of error we should return if MDM is not configured (see comment)
[x] Return an error when the VPP token is expired and a user attempts an install Figma
[x] Confirm error for POST /api/v1/fleet/hosts/:id/software/install/:software_title_id when there's no package or VPP app, released error is: "Software title has no package added. Please add software package to install." Roberto changed it to: "Software title has no package or VPP app added. Please add software package or VPP app to install."

marko-lisica commented 1 month ago

@jahzielv Here's the copy for the error message when the API user tries to install the app without a software package or App Store app added.

fleet-release commented 4 weeks ago

Code cleanup tasks done, Device management shines bright, Fleet sails smooth at dawn.

Apple API calls, Now in a single package, Silent as the mist.

Expiration check, Cleanses code like springtime rain, Token life renewed.

Added field removed, Clear as a glass city’s view, Code simplicity.

Fetching data, retry, Resilient as a cloud's drift, iTunes endpoint served.

Country code non-issue, Future-proof as the rising sun, For now, we rest easy.

Management flags set, Research ahead, path unsure, Yet, Fleet stands steady.

Source field now updated, Apps stand tall in the skyline, UI clarity.

Temporary access, Replaced by datastore methods, Stable as a mountain.

VPP token stored, Raw or encoded, we ponder, Base64 chosen.

Integration tests added, Software titles listed, clear, Datastore methods shine.

Error return discussed, MDM configuration checked, Fleet sails on, error-free.

Expired token blocked, Installation attempt thwarted, Safety in the code.

No package or VPP, Clear error message returned, Honesty in code.

Fleet, now polished bright, Like a city in the clouds, Code cleanup tasks done.

fleetdm / fleet