Open lukeheath opened 1 month ago
Thanks for tracking this @lukeheath.
I spoke with @spokanemac and he mentioned this is happening because the file upload is timing out. Not notifying the user there is a file upload maximum, or telling them when it gets reached, is a bug that I'll file separately.
I don't think max file size is the issue. The expected max file size is 500 MB and, looking at the bug here, it looks like you uploaded a 204 MB package.
Rather, I think we're not showing the right error message when the user hits the 2 minute timeout.
I think it makes sense to fix that wrong error message bug and then follow up w/ this progress indicator improvement separately.
Converting issue description to a story format and moving original issue description here:
When uploading large software files, the indeterminate loading spinner doesn't make clear how far along my progress is, or if the file upload has stalled. After waiting several minutes, mine closed and I got an error saying it couldn't complete.
I spoke with @spokanemac and he mentioned this is happening because the file upload is timing out. Not notifying the user there is a file upload maximum, or telling them when it gets reached, is a bug that I'll file separately.
UPDATE: I think that it's not the file size maximum. The maximum is 500 MB (noahtalerman 2024-07-11)
Upload Google Chrome universal installer.
Hey @georgekarrv heads up that it looks like we missed estimating this one before today's sprint kickoff.
I think we missed it because it didn't have the #g-mdm
label?
I left it in the ready for spec column. Do you think we can estimate this one at the next standup and bring it into the current sprint if we have room?
cc @lukeheath
I started to self-assign before I realized the scope has grown quite a bit.
@ghernandez345 I put together a draft PR proposing this which may or may not be a helpful starting point: https://github.com/fleetdm/fleet/pull/19086. Up to you!
Hey team! Please add your planning poker estimate with Zenhub @ghernandez345 @gillespi314
As we prepare for app library next sprint we're escalating this to P2 so that it can be prioritized over bugs. Some of the packages that will be uploaded are very large, and on a less-than-stellar connection can take several minutes to finish. If we just using a loading spinner without indicating process, it appears broken after a couple of minutes of spinning, even if it's still in progress.
Goal
Context
Changes
Product
Engineering
QA
Risk assessment
Manual testing steps
Testing notes
Confirmation