search

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
2.92k stars 404 forks source link

Edit packages #20404

Open marko-lisica opened 1 month ago

marko-lisica commented 1 month ago

Goal

User story
As an IT admin,
I want to edit a package by uploading a new package and/or editing the package's attributes (pre-install condition, install script, post-install script, self-service, etc.)
so that I can update the software on my workstations.

Context

Changes

Product

Engineering

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

Manual testing steps

  1. Step 1
  2. Step 2
  3. Step 3

Testing notes

Confirmation

  1. [ ] Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. [ ] QA (@____): Added comment to user story confirming successful completion of QA.
noahtalerman commented 1 month ago

Thanks for tracking this @marko-lisica!

This is a clear UX improvement and probably a quick win so it makes sense to take this as part of the upcoming design sprint.

I think I've heard this request come from several customers and folks at Fleet internally.

cc @lukeheath @pintomi1989 @ddribeiro @zayhanlon @Patagonia121

noahtalerman commented 1 month ago

@marko-lisica I think it makes sense to include editing "self-service" as part of this story too.

Closing out the "Switch software to self-service after it has already been uploaded" story (#20372).

cc @pintomi1989

noahtalerman commented 1 month ago

Hey @marko-lisica heads up, I updated this issue to user story format and moved your original issue description here:

Problem

After the upload, there's no way to edit the software's advanced options (install script, post-install script, etc.). The only way is to remove software package and re-upload with new options. This isn't very pleasant if a user is testing new package and scripts attached to it.

New packages are usually tested before production deployment. IT admin should be able to test different options easily before pushing to production.

I experienced this while dogfooding and testing scripts for .exe installers.

Potential solutions

After the software package is uploaded, allow user to edit stuff in the advanced options modal.

Screenshot 2024-07-12 at 13 34 30
noahtalerman commented 3 weeks ago

Mike: Let's be aware of where this heads w/ Andriod i.e. esper (and iOS)

sharon-fdm commented 1 week ago

Very early estimations (We do not have Figma at this point): BE: 5 GOps: 5 FE - 5-8 (really hard without Figma)?

sharon-fdm commented 1 week ago

BE - Tim 10 Points FE - Ian 8 Points

mostlikelee commented 1 week ago

@rachaelshaw I created a draft PR for your review. Feel free to edit.

lucasmrod commented 5 days ago

@marko-lisica @mostlikelee

I'm adding "author" to uploaded software installers in https://github.com/fleetdm/fleet/issues/21428.

So, editing an installer should update the author IMO. If user A uploads a package, then user B modifies it (modifies install script or uploads another the installer, etc.), we should update the author of the package to be user B, right?

marko-lisica commented 4 days ago

@marko-lisica @mostlikelee

I'm adding "author" to uploaded software installers in #21428.

So, editing an installer should update the author IMO. If user A uploads a package, then user B modifies it (modifies install script or uploads another the installer, etc.), we should update the author of the package to be user B, right?

@lucasmrod Sounds good to me.