search

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
2.92k stars 406 forks source link

Calendar feature creating events in the past #20452

Closed Drew-P-drawers closed 1 month ago

Drew-P-drawers commented 1 month ago

Fleet version: Fleet 0.0.0-SNAPSHOT-ec2d21a • Go go1.22.4

Web browser and operating system:

💥  Actual behavior

Fleet calendar event is creating events in the past, and not triggering the webhook to Tines when moving this event to the present.

🧑‍💻  Steps to reproduce

  1. When failing a policy (macOS - system maintenance complete), a calendar event is created. Delete this event.
  2. Adjust the policy "macOS - System maintenance complete" to force the host to pass the policy. (Change device host name)
  3. Refetch the host device
  4. Adjust the policy to force the host to fail the policy
  5. Refetch the host device.

🕯️ More info (optional)

System maintenance was populated on May 21st.

User 1: image

User 2:

image
lukeheath commented 1 month ago

@Drew-P-drawers Thanks for filing! You can use the fast track for Fleeties and move it directly to the reproduce state.

@sharon-fdm @xpkoala This may have been an unreleased bug that ended up being released. Today we realized there is a bug in the calendar (maybe this?) that is resulting in a critical patch on Monday. This should have been release blocking until it was properly triaged.

sharon-fdm commented 1 month ago

Timebox 1 point to reproduce.

xpkoala commented 1 month ago

I'm not able to reproduce this on the 4.55 RC. There have been a large number of fixes for the calendar feature added since last release. Closing this out.

fleet-release commented 1 month ago

Past events arise, Fleet now corrects the flow, Time dances in line.