Maintenance window created when end user is out of office (OOO)

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)

https://fleetdm.com

Other

3.07k stars 426 forks source link

Maintenance window created when end user is out of office (OOO) #20454

Open Drew-P-drawers opened 3 months ago

Drew-P-drawers commented 3 months ago

Fleet version: Fleet 0.0.0-SNAPSHOT-ec2d21a • Go go1.22.4

Web browser and operating system:

💥 Actual behavior

Fleet calendar events being populated on days where a user has set that they're out of office

🧑‍💻 Steps to reproduce

When failing a policy (macOS - system maintenance complete), a calendar event is created. Delete this event.
Adjust the policy "macOS - System maintenance complete" to force the host to pass the policy. (Change device host name)
Refetch the host device
Adjust the policy to force the host to fail the policy
Refetch the host device.

🕯️ More info (optional)

getvictor commented 3 months ago

@Drew-P-drawers We don't support out-of-office. Can you convert this into a feature fest item? What if the user's calendar is all out-of-office (or, say, 3 months out of office)? We probably want to flag that somehow.

noahtalerman commented 3 months ago

Hey @Drew-P-drawers thanks for tracking this!

Hey @getvictor, I'm checking out Drew's screenshot (orange calendar events).

Do y'all know why there are 7 events scheduled during that OOO day? Also, one is titled "Scheduled maintenance" and the remaining are titled "Downtime." Why is that?

Asking because I'm wondering if we have a bug where we schedule more than one event during a single day.

Drew-P-drawers commented 3 months ago

I'm thinking this is a bug @noahtalerman

I only noticed the additional events because of the out of office scheduling, and in the past.

Wasn't sure if the additional events were created before any improvements were made and can't replicate with the 14.5 policy

noahtalerman commented 3 months ago

I'm thinking this is a bug @noahtalerman

Got it @Drew-P-drawers! When you get the chance, can you please file a separate "Multiple calendar events during the same day" bug so we can dig into that?

Thanks!

getvictor commented 3 months ago

@Drew-P-drawers If you tell me whose calendar it is, I can get some metadata from those events, like when they were created, etc. I did not see any events on your calendar.

Drew-P-drawers commented 3 months ago

It was Paul's calendar back on May 21st @getvictor

Thanks for looking into this!

getvictor commented 3 months ago

As part of this story, we should also check the working hours that users have set to see if they are outside 9am-5pm window. For example, suppose I'm in Europe and working 2pm-10pm to match with US workday.

Drew-P-drawers commented 2 months ago

Just noting here that it's still happening

sharon-fdm commented 2 months ago

@Drew-P-drawers , this is my mistake, I thought it's a bug. But it turns out that we do not support OOO at the moment. Need to go through Feature Fest.

noahtalerman commented 1 month ago

Agree that this is a feature request and we're not pursuing maintenance improvements right now.

Just noting here that it's still happening

Hey @lukeheath, it looks like @mikermcneil's laptop is still in "💻🐣 Workstations (canary)" and calendar events are enabled for that team.

Thus, he's getting calendar events.

Should Mike's laptop still be in canary?

I can't remember, did we decide to leave calendar events on in canary?

cc @Drew-P-drawers

lukeheath commented 1 month ago

@noahtalerman Yes, we still have calendar events enabled for canary in case anyone wants to demo it for the "run script on calendar event" workflow. I have moved Mike to the workstations teams, which has calendar events disabled, so he shouldn't get more events.