search

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
2.89k stars 402 forks source link

Tines not receiving webhook from Calendar events #20456

Closed Drew-P-drawers closed 3 weeks ago

Drew-P-drawers commented 1 month ago

Fleet version: Fleet 0.0.0-SNAPSHOT-ec2d21a • Go go1.22.4

Web browser and operating system:

💥  Actual behavior

Tines not receiving webhook from Calendar events

🧑‍💻  Steps to reproduce

  1. When failing a policy (macOS - system maintenance complete), a calendar event is created. Delete this event.
  2. Adjust the policy "macOS - System maintenance complete" to force the host to pass the policy. (Change device host name)
  3. Refetch the host device
  4. Adjust the policy to force the host to fail the policy
  5. Refetch the host device.
  6. Move scheduled maintenance window on Google Calendar to present time

🕯️ More info (optional)

Once we enter into a scheduled maintenance window, we expect to see the webhook being received by Tines. We attempted with multiple AE's during the Sales enablement meeting. We are not receiving any logs within Tines that a webhook is being fired.

image

getvictor commented 1 month ago

@Drew-P-drawers, we recently fixed a few unreleased bugs in the RC, and I'm not able to reproduce this running with the latest code (which is not on Dogfood yet).

https://www.loom.com/share/01a64d3f387d48cabe968b4cc20a11a7

Let's plan to reproduce again after we finish the QA for this release.

lukeheath commented 1 month ago

@Drew-P-drawers Are you still able to reproduce this? It may have been fixed. If not, please close. Thanks!

Drew-P-drawers commented 1 month ago

Im actually not able to see any calendar activity when failing the policy when trying to recreate this now @lukeheath

lukeheath commented 1 month ago

@sharon-fdm @getvictor It looks like the calendar feature may be non-functional in dogfood. We're still demoing that feature, so I'm escalating this to a P2.

sharon-fdm commented 1 month ago

Thanks @lukeheath. We are looking into this to solve asap.

sharon-fdm commented 4 weeks ago

@xpkoala, close?

Drew-P-drawers commented 4 weeks ago

It looks like it's starting to receive the webhooks in Tines and generate the calendar events.

image image

sharon-fdm commented 4 weeks ago

@getvictor, can you please attach the PR? (Or close this if it's duplicated)

sharon-fdm commented 4 weeks ago

20283

sharon-fdm commented 4 weeks ago

Duplicate. removing the milestone so not to include twice.

lukeheath commented 3 weeks ago

@jacobshandling @sharon-fdm Can this be closed, or is there still work to do?

fleet-release commented 3 weeks ago

Calendar events lost, Fleet's hand reaches through the cloud, Webhook's path is found.

jacobshandling commented 3 weeks ago

@lukeheath it can be closed. The recent re-assignment was to indicate that another PR I put in also fixed this issue, not that there is more work to do.

sharon-fdm commented 3 weeks ago

@lukeheath, closed. I brought it as a w\a for the release. It's a duplicate, done and closed.